Skip to content

Commit cd12345

Browse files
four4fishcarmocca
andcommitted
Apply suggestions from code review
Co-authored-by: Carlos Mocholí <[email protected]>
1 parent caaf390 commit cd12345

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

pytorch_lightning/strategies/parallel.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,6 @@ def distributed_sampler_kwargs(self):
8585
distributed_sampler_kwargs = dict(num_replicas=len(self.parallel_devices), rank=self.global_rank)
8686
return distributed_sampler_kwargs
8787

88-
@property
89-
def parallel_devices(self):
90-
return self._parallel_devices
91-
92-
@parallel_devices.setter
93-
def parallel_devices(self, parallel_devices):
94-
self._parallel_devices = parallel_devices
95-
9688
def reconciliate_processes(self, trace: str):
9789
"""Function to re-conciliate processes on failure."""
9890

pytorch_lightning/utilities/device_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from pytorch_lightning.utilities.exceptions import MisconfigurationException
2222

2323

24-
def determine_root_gpu_device(gpus: List[Union[int, torch.device]]) -> Optional[Union[int, torch.device]]:
24+
def determine_root_gpu_device(gpus: List[_DEVICE]) -> Optional[_DEVICE]:
2525
"""
2626
Args:
2727
gpus: non-empty list of ints representing which gpus to use

0 commit comments

Comments
 (0)