Skip to content

Commit f1882aa

Browse files
authored
[Fault Tolerance] Don't check the len of a dataset, but its instance. (#10432)
1 parent edbf274 commit f1882aa

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pytorch_lightning/trainer/data_loading.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
CaptureMapDataset,
3838
FastForwardSampler,
3939
)
40-
from pytorch_lightning.utilities.data import has_iterable_dataset, has_len_all_ranks
40+
from pytorch_lightning.utilities.data import get_len, has_iterable_dataset, has_len_all_ranks
4141
from pytorch_lightning.utilities.enums import DistributedType
4242
from pytorch_lightning.utilities.exceptions import MisconfigurationException
4343
from pytorch_lightning.utilities.imports import _fault_tolerant_training
@@ -282,10 +282,11 @@ def _get_dataloader_init_kwargs(
282282
dl_kwargs["sampler"] = None
283283

284284
if _fault_tolerant_training():
285-
if isinstance(dl_kwargs["dataset"], IterableDataset):
285+
dataset = dl_kwargs["dataset"]
286+
if isinstance(dataset, IterableDataset):
286287
# wrap the `IterableDataset` into a `CaptureIterableDataset` to record sampler states.
287288
dl_kwargs["dataset"] = CaptureIterableDataset(dataset=dl_kwargs["dataset"])
288-
elif len(dl_kwargs["dataset"]):
289+
elif get_len(dataset) != float("inf"):
289290
dl_kwargs["dataset"] = CaptureMapDataset(dataset=dl_kwargs["dataset"])
290291
else:
291292
raise MisconfigurationException(

0 commit comments

Comments
 (0)