Skip to content

Commit f87b2ef

Browse files
authored
Remove GradInformation module, including from LightningModule hierarchy (#8831)
* Remove GradInformation module from LightningModule hierarchy
1 parent 6de66eb commit f87b2ef

File tree

4 files changed

+4
-45
lines changed

4 files changed

+4
-45
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
9595

9696
- `Trainer.request_dataloader` now takes a `RunningStage` enum instance ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))
9797

98+
9899
### Deprecated
99100

100101
- Deprecated `LightningModule.summarize()` in favor of `pytorch_lightning.utilities.model_summary.summarize()`
@@ -143,12 +144,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
143144
- Removed the deprecated `Trainer.truncated_bptt_steps` in favor of `LightningModule.truncated_bptt_steps` ([#8826](https://github.com/PyTorchLightning/pytorch-lightning/pull/8826))
144145

145146

146-
- Removed `LightningModule.write_predictions` and `LightningModule.write_predictions_dict` ([#](https://github.com/PyTorchLightning/pytorch-lightning/pull/8850))
147+
- Removed `LightningModule.write_predictions` and `LightningModule.write_predictions_dict` ([#8850](https://github.com/PyTorchLightning/pytorch-lightning/pull/8850))
147148

148149

149150
- Removed reset dataloader hooks to Training Plugins and Accelerators ([#8858](https://github.com/PyTorchLightning/pytorch-lightning/pull/8858))
150151

151152

153+
- Removed deprecated `GradInformation` module in favor of `pytorch_lightning.utilities.grads` ([#8831](https://github.com/PyTorchLightning/pytorch-lightning/pull/8831/))
154+
152155

153156
### Fixed
154157

pytorch_lightning/core/grads.py

Lines changed: 0 additions & 36 deletions
This file was deleted.

pytorch_lightning/core/lightning.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
from torch.optim.optimizer import Optimizer
3232
from torchmetrics import Metric
3333

34-
from pytorch_lightning.core.grads import GradInformation
3534
from pytorch_lightning.core.hooks import CheckpointHooks, DataHooks, ModelHooks
3635
from pytorch_lightning.core.mixins import DeviceDtypeModuleMixin, HyperparametersMixin
3736
from pytorch_lightning.core.optimizer import LightningOptimizer
@@ -57,7 +56,6 @@ class LightningModule(
5756
ABC,
5857
DeviceDtypeModuleMixin,
5958
HyperparametersMixin,
60-
GradInformation,
6159
ModelIO,
6260
ModelHooks,
6361
DataHooks,

tests/deprecated_api/test_remove_1-5.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,6 @@ def bar(self):
161161
pass
162162

163163

164-
def test_v1_5_0_lighting_module_grad_norm(tmpdir):
165-
model = BoringModel()
166-
with pytest.deprecated_call(match="is deprecated in v1.3 and will be removed in v1.5"):
167-
model.grad_norm(2)
168-
169-
170164
def test_v1_5_0_datamodule_setter():
171165
model = BoringModel()
172166
datamodule = BoringDataModule()

0 commit comments

Comments
 (0)