Skip to content

Deprecate TrainerDataLoadingMixin and move logic to DataConnector #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daniellepintz opened this issue Dec 24, 2021 · 0 comments · Fixed by #11282
Closed

Deprecate TrainerDataLoadingMixin and move logic to DataConnector #11248

daniellepintz opened this issue Dec 24, 2021 · 0 comments · Fixed by #11282
Labels
data handling Generic data-related topic deprecation Includes a deprecation refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Dec 24, 2021 •
edited by github-actions bot
Loading

Proposed refactor

Move everything from this class:
https://github.com/PyTorchLightning/pytorch-lightning/blob/ca9b25db80f08a3b9a3c448048949ec1adb845ba/pytorch_lightning/trainer/data_loading.py#L46

to this class:
https://github.com/PyTorchLightning/pytorch-lightning/blob/ca9b25db80f08a3b9a3c448048949ec1adb845ba/pytorch_lightning/trainer/connectors/data_connector.py#L36

Motivation

The TrainerDataLoadingMixin is the last remaining Mixin after TrainerCallbackHookMixin and TrainerOptimizersMixin have been deprecated. As part of our move towards composition over inheritance, it makes sense to deprecate this last one as well and have no mixins on the Trainer class.

cc @justusschock @awaelchli @akihironitta @rohitgr7 @ninginthecloud @tchaton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data handling Generic data-related topic deprecation Includes a deprecation refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate TrainerDataLoadingMixin and move logic to DataConnector daniellepintz/pytorch-lightning
1 participant
@daniellepintz