Skip to content

Fix typing for Strategies files #11371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniellepintz opened this issue Jan 9, 2022 · 7 comments
Closed

Fix typing for Strategies files #11371

daniellepintz opened this issue Jan 9, 2022 · 7 comments
Assignees
Labels
good first issue Good for newcomers help wanted Open to be worked on refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Jan 9, 2022

Proposed refactor

Fix typing for these files:
https://github.com/PyTorchLightning/pytorch-lightning/blob/7eab379da2fdca542849ed4ad313d0851c2271e3/pyproject.toml#L70-L84

Motivation

As part of #7037 we want to add typing to the entire Lightning codebase.

Additional Context

Make sure you do one PR per file.
Start by removing the file from pyproject.toml. To test mypy locally make sure you have it installed and then simply run mypy.

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7

@daniellepintz daniellepintz added help wanted Open to be worked on good first issue Good for newcomers refactor labels Jan 9, 2022
@alat-rights
Copy link

alat-rights commented Feb 14, 2022

I would love to take this on. If I'm not missing any hidden complexities here, I should be able to get this done by today?

Edit: Might take a little longer 🙃

@awaelchli
Copy link
Contributor

Hello
This is wonderful.

We are targeting to get some refactors and API updates in for the strategies in upcoming Lightning 1.6 release (#11643, #9932). These have priority over typing, but you are welcome to start if you want. I'm only mentioning this because there are likely going to be merge conflicts so please ping us if you need help resolving these.

To start, I suggest to take some easy ones like single_tpu.py, single_device.py, dp, etc.

Thanks for the help
cheers

@alat-rights
Copy link

Sounds great, I'll take a look!

Excited to join the community.

All the best

@daniellepintz
Copy link
Contributor Author

Thanks @alat-rights! Just assigned you the issue

@mathemusician
Copy link
Contributor

mathemusician commented May 5, 2022

Hello! Permission to make a pull request for this? @daniellepintz

@Borda
Copy link
Member

Borda commented May 6, 2022

Hello! Permission to make a pull request for this? @daniellepintz

you are more then welcome to do it 🎉

@carmocca
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Open to be worked on refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants