Skip to content

Mark CheckpointConnector as protected #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daniellepintz opened this issue Jan 14, 2022 · 2 comments · Fixed by #11550
Closed

Mark CheckpointConnector as protected #11482

daniellepintz opened this issue Jan 14, 2022 · 2 comments · Fixed by #11550
Assignees
@krishnakalyan3
Labels
good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement refactor trainer: connector
Milestone
pl:1.6

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Jan 14, 2022 •
edited by github-actions bot
Loading

Proposed refactor

Mark CheckpointConnector as protected:
https://github.com/PyTorchLightning/pytorch-lightning/blob/18bbb39eef77c8c3d19789b1067164e962640c93/pytorch_lightning/trainer/trainer.py#L464

Motivation

Part of #9778

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @kaushikb11 @ninginthecloud
@awaelchli awaelchli added the let's do it! approved to implement label Jan 16, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 16, 2022
@krishnakalyan3
Copy link
Contributor

I would like to work on this!

@rohitgr7
Copy link
Contributor

@krishnakalyan3 awsome!

please go ahead with a PR :)

@krishnakalyan3 krishnakalyan3 mentioned this issue Jan 20, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnakalyan3 krishnakalyan3

Labels
good first issue Good for newcomers help wanted Open to be worked on let's do it! approved to implement refactor trainer: connector
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging a pull request may close this issue.

Mark CheckpointConnector as protected
4 participants
@krishnakalyan3 @awaelchli @rohitgr7 @daniellepintz