-
Notifications
You must be signed in to change notification settings - Fork 3.5k
🚀 Remove deprecated APIs for 1.8 release #14841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
21 of 23 tasks
Labels
breaking change
Includes a breaking change
Milestone
Comments
12 tasks
Hey @krishnakalyan3 thanks for opening the issue. But let's be clear, this is not about deprecating APIs for 1.8. Here we are talking about removals of APIs that were already deprecated in past releases. |
Yes. thanks for clarifying the description. |
5 tasks
12 tasks
This was referenced Sep 23, 2022
Repository owner
moved this from In Progress
to Done
in Frameworks Planning
Sep 24, 2022
This was referenced Sep 26, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Let's remove the deprecated 1.8 APIs together. This is a single place where we can easily track the status of the API.
Please, comment on this issue in order to reserve a particular file to work on. Once you do so, I will edit this top comment to avoid collisions. Once you think your work is finished, please open a PR referencing this issue.
Please note, that it can happen that you may need to edit more than just one file. This is fine, but please keep in mind, that the goal of your PR will be to make the check pass for the chosen file.
The steps to remove deprecated APIs below
Example - #14833
For those of you who are not familiar with the process of contributing a PR, we have prepared a simple guide that will walk you through the necessary steps. You can do it! 🚀 💪
call_hook
#14869run_stage
#14870trainer_ckpt_path_attributes
#14897trainer_optimizer_mixin
#14887trainer_data_loading_mixin
#14888device_stats_monitor.prefix_keys
#14890trainer_lightning_optimizers
#14889agg_and_log_metrics
#14840agg_and_log_metrics
#14840profile_iterable
#14864on_load/save_checkpoint
behavior #14835on_load/save_checkpoint
behavior #14835This issue is inspired by the community effort in #13445
The text was updated successfully, but these errors were encountered: