Skip to content

🚀 Remove deprecated APIs for 1.8 release #14841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
21 of 23 tasks
krishnakalyan3 opened this issue Sep 22, 2022 · 2 comments · Fixed by #14864 or #14834
Closed
21 of 23 tasks

🚀 Remove deprecated APIs for 1.8 release #14841

krishnakalyan3 opened this issue Sep 22, 2022 · 2 comments · Fixed by #14864 or #14834
Labels
breaking change Includes a breaking change
Milestone

Comments

@krishnakalyan3
Copy link
Contributor

krishnakalyan3 commented Sep 22, 2022

Let's remove the deprecated 1.8 APIs together. This is a single place where we can easily track the status of the API.

Please, comment on this issue in order to reserve a particular file to work on. Once you do so, I will edit this top comment to avoid collisions. Once you think your work is finished, please open a PR referencing this issue.

Please note, that it can happen that you may need to edit more than just one file. This is fine, but please keep in mind, that the goal of your PR will be to make the check pass for the chosen file.

The steps to remove deprecated APIs below

  • Decide on the test you want to remove
  • grep for all the occurrences of deprecation in the source code and remove
  • update changelog
  • make sure that unit tests pass

Example - #14833

For those of you who are not familiar with the process of contributing a PR, we have prepared a simple guide that will walk you through the necessary steps. You can do it! 🚀 💪

This issue is inspired by the community effort in #13445

@krishnakalyan3 krishnakalyan3 added the needs triage Waiting to be triaged by maintainers label Sep 22, 2022
@awaelchli
Copy link
Contributor

awaelchli commented Sep 22, 2022

Hey @krishnakalyan3 thanks for opening the issue. But let's be clear, this is not about deprecating APIs for 1.8. Here we are talking about removals of APIs that were already deprecated in past releases.

@awaelchli awaelchli changed the title 🚀 Deprecate API for 1.8 release 🚀 Remove deprecated APIs for 1.8 release Sep 22, 2022
@awaelchli awaelchli added breaking change Includes a breaking change and removed needs triage Waiting to be triaged by maintainers labels Sep 22, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 22, 2022
@krishnakalyan3
Copy link
Contributor Author

Yes. thanks for clarifying the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change
Projects
No open projects
Status: Done
2 participants