Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric run CLI cannot launch python module #20654

Open
jhliu17 opened this issue Mar 18, 2025 · 0 comments
Open

Fabric run CLI cannot launch python module #20654

jhliu17 opened this issue Mar 18, 2025 · 0 comments
Assignees
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@jhliu17
Copy link

jhliu17 commented Mar 18, 2025

Description & Motivation

In Fabric run CLI, the script argument always assumes the input is an existed file path. However, users might need to launch a python module.

type=click.Path(exists=True),

For example, the CLI expects

fabric run src/run.py \
    --strategy=ddp \
    --devices=2 \
    --accelerator=cuda

However, this would fail

fabric run \
    --strategy=ddp \
    --devices=2 \
    --accelerator=cuda \
    -m src.run

In huggingface accelearte, they provide an extra argument for definiing an module
https://github.com/huggingface/accelerate/blob/4b6be8991059f39a8df8893333d11c54bc51fc60/src/accelerate/commands/launch.py#L358

Pitch

No response

Alternatives

No response

Additional context

No response

cc @lantiga @Borda

@jhliu17 jhliu17 added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants