Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for flushing Comet experiment data to the Comet after saving a checkpoint. #20680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for flushing Comet experiment data to the Comet after saving a checkpoint. #20680

wants to merge 2 commits into from

Conversation

yaricom
Copy link

@yaricom yaricom commented Mar 27, 2025 •
edited
Loading

Hey, this is the PR from Comet's SDK engineer.

What does this PR do?

  • Added support for flushing Comet experiment data to the Comet after saving a checkpoint. This behavior is configurable through the flush_every parameter of the CometLogger.

Fixes #20681

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20680.org.readthedocs.build/en/20680/

@yaricom
Added support for flushing Comet experiment data to the Comet servers…
25c63f7 
… after saving a checkpoint. This behavior is configurable through the `flush_every` parameter of the `CometLogger`.
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 27, 2025
@yaricom yaricom mentioned this pull request Mar 27, 2025
Open
@yaricom yaricom marked this pull request as ready for review March 27, 2025 17:36
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (df5dee6) to head (25c63f7).

❗ There is a different number of reports uploaded between BASE (df5dee6) and HEAD (25c63f7). Click for more details.

HEAD has 599 uploads less than BASE
Flag BASE (df5dee6) HEAD (25c63f7)
cpu 161 27
python 18 3
lightning_fabric 37 0
pytest 83 0
python3.10 36 6
lightning 91 15
python3.11 36 6
python3.12.7 54 9
python3.12 17 3
gpu 3 0
pytorch2.1 18 6
pytorch_lightning 36 12
pytest-full 81 27
pytorch2.3 9 3
pytorch2.2.2 9 3
pytorch2.5 9 3
pytorch2.4.1 9 3
pytorch2.7 9 3
pytorch2.5.1 9 3
pytorch2.6 9 3
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #20680     +/-   ##
=========================================
- Coverage      87%      79%     -9%     
=========================================
  Files         268      265      -3     
  Lines       23449    23400     -49     
=========================================
- Hits        20501    18392   -2109     
- Misses       2948     5008   +2060
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Comet experiment data flush after saving checkpoint into CometLogger
1 participant
@yaricom