Skip to content

Remove InternalDebugger #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
carmocca opened this issue Sep 23, 2021 · 2 comments · Fixed by #9680
Closed
7 tasks done

Remove InternalDebugger #9661

carmocca opened this issue Sep 23, 2021 · 2 comments · Fixed by #9680
Labels
ci Continuous Integration good first issue Good for newcomers refactor
Milestone

Comments

@carmocca
Copy link
Contributor

carmocca commented Sep 23, 2021

Proposed refactoring or deprecation

See title

Motivation

The InternalDebugger is legacy and lets us to write bad code. The code should be structured in a way that enables testing.

Pitch

Additional context

Discussed in #8895


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

  • Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

  • Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

@awaelchli
Copy link
Contributor

awaelchli commented Sep 23, 2021

Thanks @carmocca
I have a branch where I started the dataloader removal a while ago.
Have you already started? This one is going to be a bit of effort. Saved it for last.

@carmocca
Copy link
Contributor Author

No, I haven't. Up for grabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration good first issue Good for newcomers refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants