Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tokio 1.0 #46

Closed
wayofthepie opened this issue Jan 11, 2021 · 3 comments · Fixed by #47
Closed

Support tokio 1.0 #46

wayofthepie opened this issue Jan 11, 2021 · 3 comments · Fixed by #47

Comments

@wayofthepie
Copy link

With tokio 1.0 released Ive been moving things over to it. It would be good to get wiremock up to 1.0 too. I had a quick look, I think all deps support 1.0 now except async-std. There is a PR for that update in async-std async-rs/async-std#924.

If this is something that you want to do I can take a look at it. Thanks.

@LukeMathWalker
Copy link
Owner

wiremock does not expose in any way its executor to the user, therefore it should work as is in a codebase that is using tokio 1.0 - did you have issues with it?

Nonetheless, updating was already on my radar (to trim to dependency tree for clients who have already migrated).
We are not using the tokio compat feature for async-std (and it is a development dependency), so it is not blocker.

If you want to take a shot at it, go ahead 😁

@wayofthepie
Copy link
Author

wayofthepie commented Jan 11, 2021

Ah you're right, I was getting a panic in the tests saying they need to run in a tokio runtime, even though they were. Thought it was a 0.2/1.0 mismatch issue, but that was not wiremock. All is good now. I can still look at this in the next few days if no one else does, would be nice to just pull in one version. Thanks!

@LukeMathWalker
Copy link
Owner

I might get to work on this today/tomorrow - let's see 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants