[ChatSetAttr] Fix bug in --mod option (Roll20#846)

* [ChatSetAttr] Fix bug in --mod option

A maximum value of 0 would (wrongly) be treated as infinity.

* [ChatSetAttr] Actually fix the problem

Author: joesinghaus

ChatSetAttr/1.9/ChatSetAttr.js

@@ -262,7 +262,8 @@ const ChatSetAttr = (function () {
 						let moddedValue = parseFloat(v) + parseFloat(attr.get(k) || "0");
 						if (!_.isNaN(moddedValue)) {
 							if (opts.modb && k === "current") {
-								moddedValue = Math.min(Math.max(moddedValue, 0), parseFloat(attr.get("max")) || Infinity);
+								const parsedMax =  parseFloat(attr.get("max"));
+								moddedValue = Math.min(Math.max(moddedValue, 0), _.isNaN(parsedMax) ? Infinity : parsedMax);
 							}
 							newValue[k] = moddedValue;
 						} else {

ChatSetAttr/ChatSetAttr.js

@@ -262,7 +262,8 @@ const ChatSetAttr = (function () {
 						let moddedValue = parseFloat(v) + parseFloat(attr.get(k) || "0");
 						if (!_.isNaN(moddedValue)) {
 							if (opts.modb && k === "current") {
-								moddedValue = Math.min(Math.max(moddedValue, 0), parseFloat(attr.get("max")) || Infinity);
+								const parsedMax =  parseFloat(attr.get("max"));
+								moddedValue = Math.min(Math.max(moddedValue, 0), _.isNaN(parsedMax) ? Infinity : parsedMax);
 							}
 							newValue[k] = moddedValue;
 						} else {