find_records_with_rbac raises exception if ids contains nil

PanSpagetka · PanSpagetka · commit 5cafa741ff08 · 2017-12-21T16:12:32.000+01:00
diff --git a/app/controllers/mixins/checked_id_mixin.rb b/app/controllers/mixins/checked_id_mixin.rb
@@ -123,6 +123,7 @@ def find_record_with_rbac(klass, id, options = {})
     #   either sets flash or raises exception
     #
     def find_records_with_rbac(klass, ids, options = {})
+      raise(_("Can't access records without id")) if ids.include?(nil) || ids.empty?
       filtered = Rbac.filtered(klass.where(:id => ids), :named_scope => options[:named_scope])
       raise(_("Can't access selected records")) unless ids.length == filtered.length
       filtered

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ def find_record_with_rbac(klass, id, options = {})`
`123`	`123`	`# either sets flash or raises exception`
`124`	`124`	`#`
`125`	`125`	`def find_records_with_rbac(klass, ids, options = {})`
	`126`	`+ raise(_("Can't access records without id")) if ids.include?(nil) \|\| ids.empty?`
`126`	`127`	`filtered = Rbac.filtered(klass.where(:id => ids), :named_scope => options[:named_scope])`
`127`	`128`	`raise(_("Can't access selected records")) unless ids.length == filtered.length`
`128`	`129`	`filtered`