Method st_delete and x_edit_tags_reset done

Author: Vratislav Hais

app/controllers/catalog_controller.rb

@@ -271,7 +271,6 @@ def x_show
   end
 
   def st_delete
-    binding.pry
     assert_privileges("catalogitem_delete")
     elements = []
     if params[:id]
@@ -283,7 +282,6 @@ def st_delete
       end
     else # showing 1 element, delete it
       elements = find_records_with_rbac(ServiceTemplate, find_checked_items).ids
-      binding.pry
       if elements.empty?
         add_flash(_("No Service Catalog Items were selected for deletion"), :error)
       end
@@ -1816,6 +1814,7 @@ def get_node_info_handle_leaf_node(id)
   # Get all info for the node about to be displayed
   def get_node_info(treenodeid, _show_list = true)
     @explorer ||= true
+    binding.pry
     @nodetype, id = parse_nodetype_and_id(valid_active_node(treenodeid))
     # saving this so it can be used while adding buttons/groups in buttons editor
     @sb[:applies_to_id] = id
@@ -2179,7 +2178,7 @@ def dialog_catalog_check
 
   def x_edit_tags_reset(db)
     @tagging = session[:tag_db] = db
-    @object_ids = find_checked_ids_with_rbac(db)
+    @object_ids = find_records_with_rbac(db.safe_constantize, find_checked_items).ids
     if params[:button] == 'reset'
       id = params[:id] if params[:id]
       return unless load_edit("#{session[:tag_db]}_edit_tags__#{id}", 'replace_cell__explorer')

spec/controllers/catalog_controller_spec.rb

@@ -19,15 +19,27 @@
   end
 
   it "checks method st_delete" do
-    binding.pry
     login_as admin_user
     allow(User).to receive(:current_user).and_return(admin_user)
     allow(controller).to receive(:checked_or_params).and_return(ServiceTemplate.all.ids)
-    controller.instance_variable_set(:@settings, {}) # @settings params in controller
     controller.instance_variable_set(:@_params, {}) # affects params in controller
+    allow(controller).to receive(:find_checked_items).and_return(ServiceTemplate.all.ids)
+    allow(controller).to receive(:replace_right_cell)
+    expect(controller).to receive(:process_sts).with(ServiceTemplate.all.ids, "destroy")
+    controller.send(:st_delete)
+  end
+
+  it "checks method x_edit_tags_reset" do
+    login_as admin_user
+    allow(User).to receive(:current_user).and_return(admin_user)
+    allow(controller).to receive(:checked_or_params).and_return(ServiceTemplate.all.ids)
+    controller.instance_variable_set(:@_params, {}) # affects params in controller
+    controller.instance_variable_set(:@sb, {:action => nil})
     allow(controller).to receive(:checked_or_params).and_return(ServiceTemplate.all.ids)
     allow(controller).to receive(:find_checked_items).and_return(ServiceTemplate.all.ids)
-    controller.send(:st_delete) 
+    allow(controller).to receive(:tag_edit_build_entries_pulldown).and_return(nil)
+    allow(controller).to receive(:replace_right_cell).with(:action => nil)
+    controller.send(:x_edit_tags_reset, "ServiceTemplate")
   end
 
   context 'get_view' do