(#60) fixed memory leak on construction of an empty frozendict

Marco-Sulla · Marco-Sulla · commit 81e163ad7caa · 2022-07-17T20:12:01.000+02:00
diff --git a/frozendict/src/3_10/frozendictobject.c b/frozendict/src/3_10/frozendictobject.c
@@ -1417,6 +1417,9 @@ static PyObject* frozendict_create_empty(
                 ((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;
                 mp->ma_version_tag = DICT_NEXT_VERSION();
             }
+            else {
+                Py_DECREF(mp);
+            }
             
             Py_INCREF(empty_frozendict);
 
diff --git a/frozendict/src/3_6/frozendictobject.c b/frozendict/src/3_6/frozendictobject.c
@@ -1418,6 +1418,9 @@ static PyObject* frozendict_create_empty(
                 ((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;
                 mp->ma_version_tag = DICT_NEXT_VERSION();
             }
+            else {
+                Py_DECREF(mp);
+            }
             
             Py_INCREF(empty_frozendict);
 
diff --git a/frozendict/src/3_7/frozendictobject.c b/frozendict/src/3_7/frozendictobject.c
@@ -1434,6 +1434,9 @@ static PyObject* frozendict_create_empty(
                 ((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;
                 mp->ma_version_tag = DICT_NEXT_VERSION();
             }
+            else {
+                Py_DECREF(mp);
+            }
             
             Py_INCREF(empty_frozendict);
 
diff --git a/frozendict/src/3_8/frozendictobject.c b/frozendict/src/3_8/frozendictobject.c
@@ -1422,6 +1422,9 @@ static PyObject* frozendict_create_empty(
                 ((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;
                 mp->ma_version_tag = DICT_NEXT_VERSION();
             }
+            else {
+                Py_DECREF(mp);
+            }
             
             Py_INCREF(empty_frozendict);
 
diff --git a/frozendict/src/3_9/frozendictobject.c b/frozendict/src/3_9/frozendictobject.c
@@ -1423,6 +1423,9 @@ static PyObject* frozendict_create_empty(
                 ((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;
                 mp->ma_version_tag = DICT_NEXT_VERSION();
             }
+            else {
+                Py_DECREF(mp);
+            }
             
             Py_INCREF(empty_frozendict);
 

Original file line number	Diff line number	Diff line change
`@@ -1417,6 +1417,9 @@ static PyObject* frozendict_create_empty(`
`1417`	`1417`	`((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;`
`1418`	`1418`	`mp->ma_version_tag = DICT_NEXT_VERSION();`
`1419`	`1419`	`}`
	`1420`	`+ else {`
	`1421`	`+ Py_DECREF(mp);`
	`1422`	`+ }`
`1420`	`1423`
`1421`	`1424`	`Py_INCREF(empty_frozendict);`
`1422`	`1425`
Original file line number	Diff line number	Diff line change
`@@ -1418,6 +1418,9 @@ static PyObject* frozendict_create_empty(`
`1418`	`1418`	`((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;`
`1419`	`1419`	`mp->ma_version_tag = DICT_NEXT_VERSION();`
`1420`	`1420`	`}`
	`1421`	`+ else {`
	`1422`	`+ Py_DECREF(mp);`
	`1423`	`+ }`
`1421`	`1424`
`1422`	`1425`	`Py_INCREF(empty_frozendict);`
`1423`	`1426`
Original file line number	Diff line number	Diff line change
`@@ -1434,6 +1434,9 @@ static PyObject* frozendict_create_empty(`
`1434`	`1434`	`((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;`
`1435`	`1435`	`mp->ma_version_tag = DICT_NEXT_VERSION();`
`1436`	`1436`	`}`
	`1437`	`+ else {`
	`1438`	`+ Py_DECREF(mp);`
	`1439`	`+ }`
`1437`	`1440`
`1438`	`1441`	`Py_INCREF(empty_frozendict);`
`1439`	`1442`
Original file line number	Diff line number	Diff line change
`@@ -1422,6 +1422,9 @@ static PyObject* frozendict_create_empty(`
`1422`	`1422`	`((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;`
`1423`	`1423`	`mp->ma_version_tag = DICT_NEXT_VERSION();`
`1424`	`1424`	`}`
	`1425`	`+ else {`
	`1426`	`+ Py_DECREF(mp);`
	`1427`	`+ }`
`1425`	`1428`
`1426`	`1429`	`Py_INCREF(empty_frozendict);`
`1427`	`1430`
Original file line number	Diff line number	Diff line change
`@@ -1423,6 +1423,9 @@ static PyObject* frozendict_create_empty(`
`1423`	`1423`	`((PyDictObject*) empty_frozendict)->ma_keys = Py_EMPTY_KEYS;`
`1424`	`1424`	`mp->ma_version_tag = DICT_NEXT_VERSION();`
`1425`	`1425`	`}`
	`1426`	`+ else {`
	`1427`	`+ Py_DECREF(mp);`
	`1428`	`+ }`
`1426`	`1429`
`1427`	`1430`	`Py_INCREF(empty_frozendict);`
`1428`	`1431`