Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 instead of Java 11 (i.e. build with - and therefore effectively require) #650

Closed
vorburger opened this issue Dec 10, 2022 · 7 comments

Comments

@vorburger
Copy link
Collaborator

Does anyone reading this have any thoughts, both Pro as well as Con, about switching this project from Java 11 to Java 17?

Recent contributors (@jejanim @chrisbloe @MazenAmria @mrdziuban @simonzkl @dassio @skyding1212 @rkumar0322 @simonzkl @bib-marko @ StruckCroissant @jamalmatgmail @gaetannandelec-ibboost @3l0w @Blanco27) any input? Do you MIND if this project were to require Java 17 instead of Java 11 in a next (future) release like 2.7.0 or 3.0.0 or whatever version number I chose for it?

This question has come up in #638.

@vorburger
Copy link
Collaborator Author

Full disclosure: I personally actually don't really care either way. I just want to avoid loosing end-users, because of this... 🤣

@3l0w
Copy link

3l0w commented Dec 12, 2022

That don't bother me, we moved our code base recently to java 17

@gaetannandelec-ibboost
Copy link

Same here, i think it would be good given main project like Spring boot 3.0 / Hibernate 6 have moved to it

@MazenAmria
Copy link
Contributor

We're considering upgrading to java 17 in the project which I'm using MariaDB4j in, so I'm fine with it.

@vorburger vorburger self-assigned this Dec 15, 2022
vorburger referenced this issue Mar 4, 2023
Due to the upcoming  switch from Java 11 to Java 17,
which warrants a major version upgrade for this project.

See https://github.com/vorburger/MariaDB4j/issues/650.
@vorburger
Copy link
Collaborator Author

OK, then let's do this - I'm switching 2.6.1 (unreleased) to 3.0.0 in #690 and will then build with Java 17 instead of 11 (perhaps not today anymore, but on another upcoming weekend or so).

@vorburger
Copy link
Collaborator Author

Resolving now, as #691 just switched the build from Java 11 to 17 (on CI, for unreleased 3.0.0, watch #696).

@vorburger
Copy link
Collaborator Author

FTR: #1144 now documents this more explictly on the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants