mzbuild: rename split_debuginfo to split-debuginfo

mzbuild convention for YAML map keys is kebab-case rather than
snake_case. See the `pre-image` key for prior art.

Author: benesch

doc/developer/mzbuild.md

@@ -419,7 +419,7 @@ publish: true
 
      Cargo is invoked with the `--release` flag unless the `--dev` flag is
      specified. The binary's debuginfo can be extracted and copied to a file in
-     the same directory named `BIN.debug` by specifying `split_debuginfo: true`.
+     the same directory named `BIN.debug` by specifying `split-debuginfo: true`.
      The binary itself will be stripped of debug information unless `strip:
      false` is requested.
 

misc/python/materialize/mzbuild.py

@@ -411,7 +411,7 @@ def __init__(self, rd: RepositoryDetails, path: Path, config: dict[str, Any]):
         example = config.pop("example", [])
         self.examples = example if isinstance(example, list) else [example]
         self.strip = config.pop("strip", True)
-        self.split_debuginfo = config.pop("split_debuginfo", False)
+        self.split_debuginfo = config.pop("split-debuginfo", False)
         self.extract = config.pop("extract", {})
         if len(self.bins) == 0 and len(self.examples) == 0:
             raise ValueError("mzbuild config is missing pre-build target")
@@ -488,7 +488,7 @@ def copy(exe: Path) -> None:
                 # images and shipping them around.
                 #
                 # This option can be used in conjuction with
-                # `split_debuginfo` and the `s3-upload-debuginfo`
+                # `split-debuginfo` and the `s3-upload-debuginfo`
                 # preimage to save the info to an S3 bucket for future use.
                 spawn.runv(
                     [*self.rd.tool("strip"), "--strip-debug", exe_path],

src/clusterd/ci/mzbuild.yml

@@ -12,7 +12,7 @@ pre-image:
   - type: cargo-build
     bin: clusterd
     strip: true
-    split_debuginfo: true
+    split-debuginfo: true
   - type: s3-upload-debuginfo
     bin: clusterd
     bucket: materialize-debuginfo

src/environmentd/ci/mzbuild.yml

@@ -12,7 +12,7 @@ pre-image:
   - type: cargo-build
     bin: environmentd
     strip: true
-    split_debuginfo: true
+    split-debuginfo: true
   - type: s3-upload-debuginfo
     bin: environmentd
     bucket: materialize-debuginfo