mz_cluster_replica_history: revert internal_replica_id

This commit reverts de57303, now that the replica ID in
mz_cluster_replica_history matches the user-facing replica ID format
again.

Author: teskje

doc/user/content/sql/system-catalog/mz_internal.md

@@ -130,7 +130,7 @@ each replica, including the times at which it was created and dropped
 <!-- RELATION_SPEC mz_internal.mz_cluster_replica_history -->
 | Field                 | Type                         | Meaning                                                                                                                                   |
 |-----------------------|------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------|
-| `internal_replica_id` | [`text`]                     | An internal identifier of a cluster replica. Guaranteed to be unique, but not guaranteed to correspond to any user-facing replica ID.     |
+| `replica_id`          | [`text`]                     | The ID of a cluster replica.                                                                                                              |
 | `size`                | [`text`]                     | The size of the cluster replica. Corresponds to [`mz_cluster_replica_sizes.size`](#mz_cluster_replica_sizes).                             |
 | `cluster_name`        | [`text`]                     | The name of the cluster associated with the replica.                                                                                      |
 | `replica_name`        | [`text`]                     | The name of the replica.                                                                                                                  |

src/adapter/src/catalog/builtin.rs

@@ -4410,7 +4410,7 @@ pub const MZ_CLUSTER_REPLICA_HISTORY: BuiltinView = BuiltinView {
                 WHERE object_type = 'cluster-replica' AND event_type = 'drop'
             )
         SELECT
-            creates.replica_id AS internal_replica_id,
+            creates.replica_id,
             creates.size,
             creates.cluster_name,
             creates.replica_name,

test/sqllogictest/audit_log.slt

@@ -179,7 +179,7 @@ SELECT occurred_at::text = '1970-01-01 00:00:00.666+00' FROM mz_audit_events ORD
 false
 
 query TTTTBBBT
-SELECT internal_replica_id, cluster_name, replica_name, size, created_at IS NOT NULL, dropped_at IS NOT NULL, created_at < dropped_at, credits_per_hour FROM mz_internal.mz_cluster_replica_history ORDER BY created_at
+SELECT replica_id, cluster_name, replica_name, size, created_at IS NOT NULL, dropped_at IS NOT NULL, created_at < dropped_at, credits_per_hour FROM mz_internal.mz_cluster_replica_history ORDER BY created_at
 ----
 u1  default  r1  1  true  false  NULL  1
 u2  foo  r  1  true  true  true  1

test/sqllogictest/autogenerated/mz_internal.slt

@@ -82,7 +82,7 @@ SELECT position, name, type FROM objects WHERE schema = 'mz_internal' AND object
 query ITT
 SELECT position, name, type FROM objects WHERE schema = 'mz_internal' AND object = 'mz_cluster_replica_history' ORDER BY position
 ----
-1  internal_replica_id  text
+1  replica_id  text
 2  size  text
 3  cluster_name  text
 4  replica_name  text

test/sqllogictest/transform/normalize_lets.slt

@@ -558,13 +558,13 @@ from
   (select
         ref_0."credits_per_hour" as c0,
         ref_0."credits_per_hour" as c1,
-        ref_0."internal_replica_id" as c2,
+        ref_0."replica_id" as c2,
         ref_0."cluster_name" as c3,
         (select "id" from mz_internal.mz_scheduling_elapsed_raw limit 1 offset 57)
            as c4
       from
         mz_internal.mz_cluster_replica_history as ref_0
-      where ref_0."internal_replica_id" is NULL
+      where ref_0."replica_id" is NULL
       limit 102) as subq_0
 where (~ (select "replication_factor" from mz_catalog.mz_clusters limit 1 offset 5)
       ) <= (~ case when (case when (((((select "details" from mz_internal.mz_sink_statuses limit 1 offset 4)