Skip to content

Commit 81a674e

Browse files
Adapt to generate_config_tests.py changes
Adapt builds and check-generated-files.sh to the fact that generate_config_tests.py does not generate test_suite_config.psa_boolean.data in Mbed TLS 4.x context anymore. Signed-off-by: Ronald Cron <[email protected]>
1 parent a1e1c2c commit 81a674e

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

scripts/make_generated_files.bat

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ perl scripts\generate_visualc_files.pl || exit /b 1
2121
@rem @@@@ programs\** @@@@
2222
cd tf-psa-crypto
2323
python scripts\generate_psa_constants.py || exit /b 1
24+
python framework\scripts\generate_config_tests.py || exit /b 1
2425
cd ..
2526

2627
@rem @@@@ tests\** @@@@
2728
python framework\scripts\generate_bignum_tests.py --directory tf-psa-crypto\tests\suites || exit /b 1
28-
python framework\scripts\generate_config_tests.py tests\suites\test_suite_config.mbedtls_boolean.data || exit /b 1
29-
python framework\scripts\generate_config_tests.py --directory tf-psa-crypto\tests\suites tests\suites\test_suite_config.psa_boolean.data || exit /b 1
29+
python framework\scripts\generate_config_tests.py || exit /b 1
3030
python framework\scripts\generate_ecp_tests.py --directory tf-psa-crypto\tests\suites || exit /b 1
3131
python framework\scripts\generate_psa_tests.py --directory tf-psa-crypto\tests\suites || exit /b 1
3232
python framework\scripts\generate_test_keys.py --output framework\tests\include\test\test_keys.h || exit /b 1

tests/CMakeLists.txt

+2-9
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,9 @@ execute_process(
1919
WORKING_DIRECTORY
2020
${CMAKE_CURRENT_SOURCE_DIR}/..
2121
OUTPUT_VARIABLE
22-
base_config_generated_data_files_raw)
22+
base_config_generated_data_files)
2323
string(REGEX REPLACE "[^;]*/" ""
24-
base_config_generated_data_files_raw "${base_config_generated_data_files_raw}")
25-
# Can be replace by list(FILTER ...) when CI CMake version is >=3.6
26-
foreach(file ${base_config_generated_data_files_raw})
27-
if(${file} MATCHES "mbedtls")
28-
list(APPEND base_config_generated_data_files ${file})
29-
endif()
30-
endforeach()
24+
base_config_generated_data_files "${base_config_generated_data_files}")
3125

3226
# Derive generated file paths in the build directory. The generated data
3327
# files go into the suites/ subdirectory.
@@ -50,7 +44,6 @@ if(GEN_FILES)
5044
${MBEDTLS_PYTHON_EXECUTABLE}
5145
${MBEDTLS_FRAMEWORK_DIR}/scripts/generate_config_tests.py
5246
--directory ${CMAKE_CURRENT_BINARY_DIR}/suites
53-
${config_generated_data_files}
5447
DEPENDS
5548
${MBEDTLS_FRAMEWORK_DIR}/scripts/generate_config_tests.py
5649
# Do not declare the configuration files as dependencies: they

tests/Makefile

+14-7
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,23 @@ $(error "$(PYTHON) ../framework/scripts/generate_bignum_tests.py --list" failed)
2525
endif
2626
GENERATED_CRYPTO_DATA_FILES += $(GENERATED_BIGNUM_DATA_FILES)
2727

28-
GENERATED_CONFIG_DATA_FILES_RAW := $(patsubst tests/%,%,$(shell \
28+
GENERATED_MBEDTLS_CONFIG_DATA_FILES := $(patsubst tests/%,%,$(shell \
2929
$(PYTHON) ../framework/scripts/generate_config_tests.py --list || \
3030
echo FAILED \
3131
))
32-
ifeq ($(GENERATED_CONFIG_DATA_FILES),FAILED)
32+
ifeq ($(GENERATED_MBEDTLS_CONFIG_DATA_FILES),FAILED)
3333
$(error "$(PYTHON) ../framework/scripts/generate_config_tests.py --list" failed)
3434
endif
35-
GENERATED_MBEDTLS_CONFIG_DATA_FILES := $(foreach file,$(GENERATED_CONFIG_DATA_FILES_RAW),$(if $(findstring mbedtls,$(file)),$(file),))
36-
GENERATED_PSA_CONFIG_DATA_FILES := $(foreach file,$(GENERATED_CONFIG_DATA_FILES_RAW),$(if $(findstring psa,$(file)),$(addprefix ../tf-psa-crypto/tests/,$(file)),))
37-
GENERATED_CONFIG_DATA_FILES := $(GENERATED_MBEDTLS_CONFIG_DATA_FILES)$(GENERATED_PSA_CONFIG_DATA_FILES)
35+
36+
GENERATED_PSA_CONFIG_DATA_FILES := $(addprefix ../tf-psa-crypto/,$(shell \
37+
$(PYTHON) ../tf-psa-crypto/framework/scripts/generate_config_tests.py --list || \
38+
echo FAILED \
39+
))
40+
ifeq ($(GENERATED_PSA_CONFIG_DATA_FILES),FAILED)
41+
$(error "$(PYTHON) ../tf-psa-crypto/framework/scripts/generate_config_tests.py --list" failed)
42+
endif
43+
44+
GENERATED_CONFIG_DATA_FILES := $(GENERATED_MBEDTLS_CONFIG_DATA_FILES) $(GENERATED_PSA_CONFIG_DATA_FILES)
3845
GENERATED_DATA_FILES += $(GENERATED_MBEDTLS_CONFIG_DATA_FILES)
3946
GENERATED_CRYPTO_DATA_FILES += $(GENERATED_PSA_CONFIG_DATA_FILES)
4047

@@ -112,8 +119,8 @@ generated_config_test_data: ../framework/scripts/mbedtls_framework/test_case.py
112119
generated_config_test_data: ../framework/scripts/mbedtls_framework/test_data_generation.py
113120
generated_config_test_data:
114121
echo " Gen $(GENERATED_CONFIG_DATA_FILES)"
115-
$(PYTHON) ../framework/scripts/generate_config_tests.py $(GENERATED_MBEDTLS_CONFIG_DATA_FILES)
116-
$(PYTHON) ../framework/scripts/generate_config_tests.py --directory ../tf-psa-crypto/tests/suites $(GENERATED_PSA_CONFIG_DATA_FILES)
122+
$(PYTHON) ../framework/scripts/generate_config_tests.py
123+
cd ../tf-psa-crypto && $(PYTHON) ./framework/scripts/generate_config_tests.py
117124
.SECONDARY: generated_config_test_data
118125

119126
$(GENERATED_ECP_DATA_FILES): $(gen_file_dep) generated_ecp_test_data

tests/scripts/check-generated-files.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ check()
141141
if [ -d tf-psa-crypto ]; then
142142
cd tf-psa-crypto
143143
check scripts/generate_psa_constants.py ./programs/psa/psa_constant_names_generated.c
144-
check ../framework/scripts/generate_bignum_tests.py $(../framework/scripts/generate_bignum_tests.py --list)
145-
check ../framework/scripts/generate_config_tests.py tests/suites/test_suite_config.psa_boolean.data
146-
check ../framework/scripts/generate_ecp_tests.py $(../framework/scripts/generate_ecp_tests.py --list)
147-
check ../framework/scripts/generate_psa_tests.py $(../framework/scripts/generate_psa_tests.py --list)
144+
check framework/scripts/generate_bignum_tests.py $(framework/scripts/generate_bignum_tests.py --list)
145+
check framework/scripts/generate_config_tests.py $(framework/scripts/generate_config_tests.py --list)
146+
check framework/scripts/generate_ecp_tests.py $(framework/scripts/generate_ecp_tests.py --list)
147+
check framework/scripts/generate_psa_tests.py $(framework/scripts/generate_psa_tests.py --list)
148148
cd ..
149149
# Generated files that are present in the repository even in the development
150150
# branch. (This is intended to be temporary, until the generator scripts are

0 commit comments

Comments
 (0)