Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Proper handling/throwing of Errors #24

Open
DonovanDMC opened this issue Apr 23, 2021 · 1 comment
Open

[FEAT] Proper handling/throwing of Errors #24

DonovanDMC opened this issue Apr 23, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@DonovanDMC
Copy link

DonovanDMC commented Apr 23, 2021

Is your feature request related to a problem? Please describe.
It's annoying that there's next to no indication that creation has succeeded if you aren't looking at the response (like I wasn't), and the typings don't indicate that a rate limit object can be returned.

Describe the solution you'd like
Either add the rate limit object to the typings, and make it known it can be returned, or (what I would personally prefer) throw an error when you get ratelimited. (check status code & body)

Describe alternatives you've considered
None.

Additional context

@DonovanDMC DonovanDMC changed the title Errored requests are not obvious [FEAT] Proper handling/throwing of Errors Apr 23, 2021
@DonovanDMC
Copy link
Author

Moreover, besides ratelimiting, do something with all of the other errors, besides pretending like everything went fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants