Upgrade ol-contextmenu to v5.4.0 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, setting up a project with the peerDependencies as listed in the README results in a dependency conflict because ol=^9.0.0 is specified but ol-contextmenu 5.3.0 explicitly states ol<=8.x, which is fixed in the 5.4.0 version.
✅ Deploy Preview for vue3openlayers ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded the
ol-contextmenudependency to v5.4.0 (was v5.3.0 previously).Motivation and Context
Currently, setting up a project with the peerDependencies as listed in the README results in a dependency conflict because
ol=^9.0.0is specified but ol-contextmenu 5.3.0 explicitly statesol<=8.x, which is fixed in the 5.4.0 version that @d-koppenhagen submitted and has since been released. Therefore theoverridesworkaround in the package.json is no longer necessary.Edit: I just realised there was already an issue for this: #308
How Has This Been Tested?
Honestly I haven't tested this at all, but as the upstream change doesn't change anything than this very thing, it should be fine.™️
I hope I did everything correctly as this is the first time I commit to this project. I'm very happy to learn about anything I missed. My first intuition was to open another issue for it, but then I thought I could as well plunge forward and fix it myself :)
Types of Changes
Checklist:
If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:
output.globalsinvite.config.tssrc/demos/<Component>Demo.vuedocs/componentsguide/<Category>/<Feature>/index.mdcontaining the Demo and documentation for the componentdocs/.vitepress/config.ts