Skip to content

Typescript definition of filter missing argument #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oraknabo opened this issue Jul 10, 2024 · 0 comments
Closed

Typescript definition of filter missing argument #363

oraknabo opened this issue Jul 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@oraknabo
Copy link

I have an Interactions.OlInteractionSelect with a filter. In an older version (2.0.1), it was allowing the feature to pass like below:

const selectInteactionFilter = (feature:any) => {
  return feature.values_.name !== undefined;
};

After upgrading, I'm getting the following error:
Type '(feature: any) => boolean' is not assignable to type '() => boolean'.

on OlInteractionSelect.vue.d.ts(23, 5), this is how the filter is defined:
filter?: (() => boolean) | undefined;

Shouldn't the definition include passing a filter argument through to the function?

├── [email protected]
└── [email protected]

It's happening in VSCode, not related to OS or Browser, but I'm using:

  • OS: Manjaro Linux
  • Firefox & Chromium
@oraknabo oraknabo added the bug Something isn't working label Jul 10, 2024
@oraknabo oraknabo changed the title Typescript definition of filter Typescript definition of filter missing argument Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant