Skip to content

#370 is not fixed #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fbatschi opened this issue Aug 9, 2024 · 0 comments
Closed

#370 is not fixed #371

fbatschi opened this issue Aug 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fbatschi
Copy link

fbatschi commented Aug 9, 2024

Describe the bug
Unfortunately there is no way to reopen a issue, so i have to do a new one.

#370 seems not fixed to me. The commit 91a07ca is probably not working, since there is a ! to much in it.

Also, the warning Modify interactions needs either a either a source or features to work has a either a too much.

Affected version(s)

11.1.0

To Reproduce
Steps to reproduce the behavior:

  1. Include a <ol-interaction-modify> in a without a `'features' key.

Expected behavior

  • <ol-interaction-modify> without features works inside a <ol-source-vector>
  • <ol-interaction-modify :features="foo"> works outside a <ol-source-vector>

without warnings.

@fbatschi fbatschi added the bug Something isn't working label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant