Skip to content

[Enhancement]: Misleading Ledger error when trying to import Ledger device #31598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjisclowder opened this issue Apr 4, 2025 · 6 comments · Fixed by #31905
Closed

[Enhancement]: Misleading Ledger error when trying to import Ledger device #31598

benjisclowder opened this issue Apr 4, 2025 · 6 comments · Fixed by #31905

Comments

@benjisclowder
Copy link
Contributor

benjisclowder commented Apr 4, 2025

Describe the bug

The wallet displays misleading message: `"Multiple Ledger devices cannot be connected at the same time. To connect a new Ledger device, you'll need to first disconnect the previous one." without any Ledger being connected, creating the confusion of an already connected device and potentially user tickets created.

Expected behavior

Ledger is detected and can be imported.

Screenshots/Recordings

Screen.Recording.2025-04-04.at.13.21.24.mov

Steps to reproduce

  1. Load MetaMask
  2. Verify that no Ledger hardware wallet is connected
  3. From the accounts dropdown click "Add account or hardware wallet" --> "Hardware wallet"
  4. Select Ledger
  5. Notice on-screen misleading error

Error messages or log output

Detection stage

During release testing

Version

12.16.0

Build type

Beta

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger

Additional context

No response

Severity

No response

@benjisclowder benjisclowder added the type-bug Something isn't working label Apr 4, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Apr 4, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in Bugs by team Apr 4, 2025
@benjisclowder benjisclowder added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. release-blocker This bug is blocking the next release team-hardware-wallets regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 labels Apr 4, 2025
@metamaskbot metamaskbot added the needs-triage Issue needs to be triaged label Apr 4, 2025
@vivek-consensys
Copy link

@benjisclowder this is expected behaviour, as we added this as an enhancement to prevent users from adding multiple devices.

@benjisclowder benjisclowder removed type-bug Something isn't working Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. needs-triage Issue needs to be triaged release-blocker This bug is blocking the next release team-hardware-wallets regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 labels Apr 4, 2025
@gantunesr gantunesr reopened this Apr 4, 2025
@vivek-consensys vivek-consensys changed the title [Bug]: Ledger cannot be connected due to false connected Ledger detection [Enhancement]: Ledger cannot be connected due to false connected Ledger detection Apr 7, 2025
@metamaskbot metamaskbot added regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 needs-triage Issue needs to be triaged labels Apr 7, 2025
@gantunesr gantunesr added Sev3-low Low severity; minimal to no impact upon users and removed needs-triage Issue needs to be triaged labels Apr 7, 2025
@eriknson
Copy link
Member

eriknson commented Apr 7, 2025

@angelcheung22 angelcheung22 removed Sev3-low Low severity; minimal to no impact upon users regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 labels Apr 9, 2025
@vivek-consensys
Copy link

new figma design: https://www.figma.com/design/LLt4aaFu1OO9U9UgY5F2Zf/Ledger-error-message-when-connecting-multiple-ledgers?node-id=2-410&m=dev

@Montoya Montoya self-assigned this Apr 9, 2025
@benjisclowder benjisclowder changed the title [Enhancement]: Ledger cannot be connected due to false connected Ledger detection [Enhancement]: Misleading Ledger error when trying to import Ledger device Apr 9, 2025
@metamaskbot metamaskbot added needs-triage Issue needs to be triaged regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 labels Apr 9, 2025
@angelcheung22
Copy link

@Montoya Btw the copy we took the one from Mobile, so if you will update it, do we need to also update for mobile too in this ticket?

@Montoya
Copy link
Contributor

Montoya commented Apr 11, 2025

@angelcheung22 yes. I have updated the copy in the Figma. Ready for implementation @Akaryatrh.

@Montoya Montoya removed their assignment Apr 11, 2025
@racitores racitores marked this as a duplicate of #32234 Apr 24, 2025
github-merge-queue bot pushed a commit that referenced this issue Apr 28, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

As previous message styling and wording could be misleading to the user
(he could believe there was an error), it has been decided to use an
informative banner instead.

Please check related Figma design screen:
https://www.figma.com/design/LLt4aaFu1OO9U9UgY5F2Zf/Ledger-error-message-when-connecting-multiple-ledgers?node-id=2-404&t=YBp8SVJBTfG4Z6is-1

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31905?quickstart=1)

## **Related issues**

Fixes: #31598

## **Manual testing steps**

1. To to device selection page (add hardware account)
2. select ledger device
3. banner should be displayed
4. select another device
5. banner should be hidden

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="1117" alt="Capture d’écran 2025-04-11 à 20 12 54"
src="https://github.com/user-attachments/assets/6349e9e3-c5b6-48a3-99c2-8924a906d6ec"
/>

### **After**

<img width="1108" alt="Capture d’écran 2025-04-11 à 20 03 10"
src="https://github.com/user-attachments/assets/9d64c139-1901-4236-a39f-0c9a2c264494"
/>

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@angelcheung22 angelcheung22 removed the regression-RC-12.16.0 Regression bug that was found in release candidate (RC) for release 12.16.0 label Apr 29, 2025
@angelcheung22
Copy link

Target release RC 12.19.

@angelcheung22 angelcheung22 added this to the Q2 2025 BE HW milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: To be triaged
Development

Successfully merging a pull request may close this issue.

8 participants