-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Enhancement]: Misleading Ledger error when trying to import Ledger device #31598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
@benjisclowder this is expected behaviour, as we added this as an enhancement to prevent users from adding multiple devices. |
@Montoya Btw the copy we took the one from Mobile, so if you will update it, do we need to also update for mobile too in this ticket? |
@angelcheung22 yes. I have updated the copy in the Figma. Ready for implementation @Akaryatrh. |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 28, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** As previous message styling and wording could be misleading to the user (he could believe there was an error), it has been decided to use an informative banner instead. Please check related Figma design screen: https://www.figma.com/design/LLt4aaFu1OO9U9UgY5F2Zf/Ledger-error-message-when-connecting-multiple-ledgers?node-id=2-404&t=YBp8SVJBTfG4Z6is-1 [](https://codespaces.new/MetaMask/metamask-extension/pull/31905?quickstart=1) ## **Related issues** Fixes: #31598 ## **Manual testing steps** 1. To to device selection page (add hardware account) 2. select ledger device 3. banner should be displayed 4. select another device 5. banner should be hidden ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="1117" alt="Capture d’écran 2025-04-11 à 20 12 54" src="https://github.com/user-attachments/assets/6349e9e3-c5b6-48a3-99c2-8924a906d6ec" /> ### **After** <img width="1108" alt="Capture d’écran 2025-04-11 à 20 03 10" src="https://github.com/user-attachments/assets/9d64c139-1901-4236-a39f-0c9a2c264494" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Target release RC 12.19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
The wallet displays misleading message: `"Multiple Ledger devices cannot be connected at the same time. To connect a new Ledger device, you'll need to first disconnect the previous one." without any Ledger being connected, creating the confusion of an already connected device and potentially user tickets created.
Expected behavior
Ledger is detected and can be imported.
Screenshots/Recordings
Screen.Recording.2025-04-04.at.13.21.24.mov
Steps to reproduce
Error messages or log output
Detection stage
During release testing
Version
12.16.0
Build type
Beta
Browser
Chrome
Operating system
MacOS
Hardware wallet
Ledger
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: