Skip to content

Commit af73b3e

Browse files
HixieMinyewoo
authored andcommitted
Sync the PR template to the new style (flutter#3397)
1 parent 8200051 commit af73b3e

File tree

1 file changed

+19
-24
lines changed

1 file changed

+19
-24
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,32 @@
1-
## Description
1+
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
22

3-
*Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.*
3+
*List which issues are fixed by this PR. You must list at least one issue.*
44

5-
## Related Issues
5+
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
66

7-
*Replace this paragraph with a list of issues related to this PR from the [issue database](https://github.com/flutter/flutter/issues). Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.*
8-
9-
## Checklist
10-
11-
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
7+
## Pre-launch Checklist
128

9+
- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. `[shared_preferences]`
1310
- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
14-
- [ ] My PR includes unit or integration tests for *all* changed/updated/fixed behaviors (See [Contributor Guide]).
15-
- [ ] All existing and new tests are passing.
16-
- [ ] I updated/added relevant documentation (doc comments with `///`).
17-
- [ ] The analyzer (`flutter analyze`) does not report any problems on my PR.
18-
- [ ] I read and followed the [Flutter Style Guide].
19-
- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
11+
- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
12+
- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
13+
- [ ] I listed at least one issue that this PR fixes in the description above.
14+
- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
2015
- [ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
2116
- [ ] I updated CHANGELOG.md to add a description of the change.
17+
- [ ] I updated/added relevant documentation (doc comments with `///`).
2218
- [ ] I signed the [CLA].
23-
- [ ] I am willing to follow-up on review comments in a timely manner.
24-
25-
## Breaking Change
26-
27-
Does your PR require plugin users to manually update their apps to accommodate your change?
19+
- [ ] All existing and new tests are passing.
2820

29-
- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
30-
- [ ] No, this is *not* a breaking change.
21+
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
3122

3223
<!-- Links -->
33-
[issue database]: https://github.com/flutter/flutter/issues
34-
[Contributor Guide]: https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md
24+
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
25+
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
3526
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
36-
[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning
27+
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/master/CONTRIBUTING.md#style
3728
[CLA]: https://cla.developers.google.com/
29+
[flutter/tests]: https://github.com/flutter/tests
30+
[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
31+
[Discord]: https://github.com/flutter/flutter/wiki/Chat
32+
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning

0 commit comments

Comments
 (0)