Skip to content

Commit 3a99bb1

Browse files
committed
Fix a type comment, make things use a shared noop where helpful
1 parent d4b29dc commit 3a99bb1

File tree

5 files changed

+17
-20
lines changed

5 files changed

+17
-20
lines changed

src/core.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable no-bitwise */
2-
import {checkCallback, hasOwn, invokeRedrawable} from "./util.js"
2+
import {checkCallback, hasOwn, invokeRedrawable, noop} from "./util.js"
33

44
export {m as default}
55

@@ -773,7 +773,7 @@ var removeNodeDispatch = [
773773
removeNode,
774774
removeElement,
775775
removeInstance,
776-
() => {},
776+
noop,
777777
(old) => currentHooks.push(old),
778778
removeFragment,
779779
removeFragment,

src/std/lazy.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import m from "../core.js"
22

3-
import {checkCallback} from "../util.js"
3+
import {checkCallback, noop} from "../util.js"
44

55
var lazy = (opts) => {
66
checkCallback(opts.fetch, false, "opts.fetch")
@@ -15,6 +15,7 @@ var lazy = (opts) => {
1515
return opts.pending && opts.pending()
1616
}
1717
var init = async () => {
18+
init = noop
1819
try {
1920
Comp = await opts.fetch()
2021
if (typeof Comp !== "function") {
@@ -31,9 +32,7 @@ var lazy = (opts) => {
3132
}
3233

3334
return (attrs) => {
34-
var f = init
35-
init = null
36-
if (typeof f === "function") f()
35+
init()
3736
return m(Comp, attrs)
3837
}
3938
}

src/std/rate-limit.js

+9-13
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
/* global performance, setTimeout, clearTimeout */
22

3+
import {noop} from "../util.js"
4+
35
var validateDelay = (delay) => {
46
if (!Number.isFinite(delay) || delay <= 0) {
57
throw new RangeError("Timer delay must be finite and positive")
@@ -12,25 +14,21 @@ var rateLimiterImpl = (delay = 500, isThrottler) => {
1214
var closed = false
1315
var start = 0
1416
var timer = 0
15-
var resolveNext
17+
var resolveNext = noop
1618

1719
var callback = () => {
1820
timer = undefined
19-
if (typeof resolveNext === "function") {
20-
resolveNext(false)
21-
resolveNext = undefined
22-
}
21+
resolveNext(false)
22+
resolveNext = noop
2323
}
2424

2525
var rateLimiter = async (ignoreLeading) => {
2626
if (closed) {
2727
return true
2828
}
2929

30-
if (typeof resolveNext === "function") {
31-
resolveNext(true)
32-
resolveNext = null
33-
}
30+
resolveNext(true)
31+
resolveNext = noop
3432

3533
if (timer) {
3634
if (isThrottler) {
@@ -66,10 +64,8 @@ var rateLimiterImpl = (delay = 500, isThrottler) => {
6664
if (closed) return
6765
closed = true
6866
clearTimeout(timer)
69-
if (typeof resolveNext === "function") {
70-
resolveNext(true)
71-
resolveNext = null
72-
}
67+
resolveNext(true)
68+
resolveNext = noop
7369
}
7470

7571
return rateLimiter

src/std/tracked.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ import {checkCallback} from "../util.js"
6565
* @property {() => Array<[K, V]>} list
6666
* @property {(key: K) => boolean} has
6767
* @property {(key: K) => undefined | V} get
68-
* @property {(key: K, value: V) => void} track
68+
* @property {(key: K, value: V) => void} set
6969
* @property {(key: K, value: V) => void} replace
7070
* @property {(key: K) => boolean} delete
7171
*/

src/util.js

+2
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,5 @@ export var checkCallback = (callback, allowNull, label = "callback") => {
1616

1717
throw new TypeError(`\`${label}\` must be a function${allowNull ? " if provided." : "."}`)
1818
}
19+
20+
export var noop = () => {}

0 commit comments

Comments
 (0)