Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Commit 3925f64

Browse files
committed
module loader 2 upgrade, babel upgrade
1 parent 176504a commit 3925f64

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

example/es-module.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import value from './es-module-dep.js';
2-
31
export default function() {
4-
return value;
5-
}
2+
return import('./es-module-dep.js');
3+
}

example/example.html

+5-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
<script>
66
var loader = new BrowserESModuleLoader();
77
loader.import('./es-module.js').then(function(m) {
8-
console.log(m.default());
8+
return m.default();
9+
})
10+
.then(function (m) {
11+
console.log(m);
912
});
1013
</script>
1114

@@ -14,4 +17,4 @@
1417
console.log(fn);
1518
</script>
1619

17-
<script type="module" src="another-module.js"></script>
20+
<script type="module" src="another-module.js"></script>

package.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
{
22
"name": "browser-es-module-loader",
3-
"version": "0.2.0",
3+
"version": "0.3.0",
44
"description": "Demonstrates ES module loading in the browser",
55
"main": "dist/browser-es-module-loader.js",
66
"author": "Guy Bedford",
77
"license": "MIT",
88
"devDependencies": {
9-
"babel-core": "^6.13.2",
10-
"babel-plugin-transform-es2015-modules-systemjs": "^6.12.0",
9+
"babel-core": "^6.22.1",
10+
"babel-plugin-syntax-dynamic-import": "^6.18.0",
11+
"babel-plugin-transform-es2015-modules-systemjs": "^6.22.0",
1112
"browserify": "^13.1.0",
1213
"es-module-loader": "^2.0.0",
1314
"rollup": "^0.34.7",

src/babel-browser-build.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
window.babel = require('babel-core');
2-
window.babelPluginTransformES2015ModulesSystemJS = require('babel-plugin-transform-es2015-modules-systemjs');
2+
window.babelPluginTransformES2015ModulesSystemJS = require('babel-plugin-transform-es2015-modules-systemjs');
3+
window.babelPluginSyntaxDynamicImport = require('babel-plugin-syntax-dynamic-import');

src/browser-es-module-loader.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { InternalModuleNamespace as ModuleNamespace } from 'es-module-loader/cor
44
import { baseURI, global, isBrowser } from 'es-module-loader/core/common.js';
55
import { resolveIfNotPlain } from 'es-module-loader/core/resolve.js';
66

7-
if (!window.babel || !window.babelPluginTransformES2015ModulesSystemJS)
7+
if (!window.babel || !window.babelPluginTransformES2015ModulesSystemJS || !window.babelPluginSyntaxDynamicImport)
88
throw new Error('babel-browser-build.js must be loaded first');
99

1010
var loader;
@@ -131,7 +131,7 @@ BrowserESModuleLoader.prototype[RegisterLoader.instantiate] = function(key, proc
131131
sourceFileName: key,
132132
moduleIds: false,
133133
sourceMaps: 'inline',
134-
plugins: [babelPluginTransformES2015ModulesSystemJS]
134+
plugins: [babelPluginSyntaxDynamicImport, babelPluginTransformES2015ModulesSystemJS]
135135
});
136136

137137
// evaluate without require, exports and module variables

0 commit comments

Comments
 (0)