Skip to content

Commit adc0fe8

Browse files
committed
use axios instead of qs
1 parent 8d6ce78 commit adc0fe8

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
"dependencies": {
4747
"atlassian-jwt": "^1.0.3",
4848
"axios": "^0.21.0",
49-
"oauth": "^0.9.15",
50-
"qs": "^6.9.4"
49+
"oauth": "^0.9.15"
5150
}
5251
}

src/helpers/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { AxiosRequestConfig } from 'axios';
22
import * as jwt from 'atlassian-jwt';
33
import * as url from 'url';
44
import { OAuth } from 'oauth';
5-
import * as qs from 'qs';
5+
import * as buildFullPath from 'axios/lib/core/buildFullPath';
6+
import * as buildURL from 'axios/lib/helpers/buildURL';
67
import { Config } from '../config';
78

89
export const getAuthentication = (
@@ -45,7 +46,7 @@ export const getAuthentication = (
4546
);
4647

4748
return oauth.authHeader(
48-
`${config.host + request.url!}?${qs.stringify(request.params)}`,
49+
buildURL(buildFullPath(config.host, request.url), request.params),
4950
config.authentication.oauth1.accessToken,
5051
config.authentication.oauth1.tokenSecret,
5152
request.method!,

tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
"DOM"
88
],
99
"declaration": true,
10-
"strict": true
10+
"strict": true,
11+
"noImplicitAny": false
1112
},
1213
"exclude": [
1314
"./tests",

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3795,11 +3795,6 @@ punycode@^2.1.0, punycode@^2.1.1:
37953795
resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz"
37963796
integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==
37973797

3798-
qs@^6.9.4:
3799-
version "6.9.4"
3800-
resolved "https://registry.yarnpkg.com/qs/-/qs-6.9.4.tgz#9090b290d1f91728d3c22e54843ca44aea5ab687"
3801-
integrity sha512-A1kFqHekCTM7cz0udomYUoYNWjBebHm/5wzU/XqrBRBNWectVH0QIiN+NEcZ0Dte5hvzHwbr8+XQmguPhJ6WdQ==
3802-
38033798
qs@~6.5.2:
38043799
version "6.5.2"
38053800
resolved "https://registry.npmjs.org/qs/-/qs-6.5.2.tgz"

0 commit comments

Comments
 (0)