Skip to content

Commit 50df9fd

Browse files
Herton Ronaldo Krzesinskitytso
Herton Ronaldo Krzesinski
authored andcommitted
ext4: fix crash when accessing /proc/mounts concurrently
The crash was caused by a variable being erronously declared static in token2str(). In addition to /proc/mounts, the problem can also be easily replicated by accessing /proc/fs/ext4/<partition>/options in parallel: $ cat /proc/fs/ext4/<partition>/options > options.txt ... and then running the following command in two different terminals: $ while diff /proc/fs/ext4/<partition>/options options.txt; do true; done This is also the cause of the following a crash while running xfstests raspberrypi#234, as reported in the following bug reports: https://bugs.launchpad.net/bugs/1053019 https://bugzilla.kernel.org/show_bug.cgi?id=47731 Signed-off-by: Herton Ronaldo Krzesinski <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]> Cc: Brad Figg <[email protected]> Cc: [email protected]
1 parent bef53b0 commit 50df9fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/ext4/super.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1749,7 +1749,7 @@ static inline void ext4_show_quota_options(struct seq_file *seq,
17491749

17501750
static const char *token2str(int token)
17511751
{
1752-
static const struct match_token *t;
1752+
const struct match_token *t;
17531753

17541754
for (t = tokens; t->token != Opt_err; t++)
17551755
if (t->token == token && !strchr(t->pattern, '='))

0 commit comments

Comments
 (0)