Skip to content

Commit 281e5c4

Browse files
authored
Exiting container when Standalone or Node exits (SeleniumHQ#1504)
* Exiting container when Standalone or Node exits
1 parent f96102b commit 281e5c4

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

.github/workflows/k8s-deploy-test.yml

+4-9
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
name: "Test Selenium Grid 4 deployment on Minikube Cluster"
22

33
on:
4-
push:
5-
branches:
6-
- trunk
7-
pull_request:
8-
branches:
9-
- trunk
4+
workflow_dispatch:
105

116
jobs:
127
deploy:
@@ -18,10 +13,10 @@ jobs:
1813
- name: Checkout
1914
uses: actions/checkout@v1
2015
- name: Setup Minikube
21-
uses: manusa/actions-setup-minikube@v2.3.0
16+
uses: manusa/actions-setup-minikube@v2.4.3
2217
with:
23-
minikube version: "v1.13.1"
24-
kubernetes version: "v1.19.2"
18+
minikube version: 'v1.24.0'
19+
kubernetes version: 'v1.23.0'
2520
github token: ${{ secrets.GITHUB_TOKEN }}
2621
driver: none
2722
- name: Interact with Minikube

NodeBase/selenium.conf

+2-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ stderr_capture_maxbytes=50MB
6161

6262
[program:selenium-node]
6363
priority=15
64-
command=/opt/bin/start-selenium-node.sh
64+
command=bash -c "/opt/bin/start-selenium-node.sh && kill -s SIGINT `cat /var/run/supervisor/supervisord.pid`"
65+
stopasgroup = true
6566
autostart=true
6667
autorestart=false
6768
startsecs=0

Standalone/selenium.conf

+2-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ stderr_capture_maxbytes=50MB
6161

6262
[program:selenium-standalone]
6363
priority=15
64-
command=/opt/bin/start-selenium-standalone.sh
64+
command=bash -c "/opt/bin/start-selenium-standalone.sh && kill -s SIGINT `cat /var/run/supervisor/supervisord.pid`"
65+
stopasgroup = true
6566
autostart=true
6667
autorestart=false
6768
startsecs=0

0 commit comments

Comments
 (0)