Skip to content

Commit 6cce381

Browse files
committed
feat(//core/conversion/converters): Throw a warning if a converter is
overridden Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent aa131ac commit 6cce381

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Diff for: core/conversion/converters/NodeConverterRegistry.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ class NodeConverterRegistry {
4848
bool RegisterConverter(torch::jit::FunctionSchema* signature, OpConverter& converter) {
4949
LOG_DEBUG("Registering converter for " << canonical_schema_string(*signature));
5050
auto name = signature->operator_name();
51+
auto iter = converter_lut_.find(name);
52+
if (iter != converter_lut_.end()) {
53+
LOG_WARNING("Overriding already registered converter " << signature->name() << ", unexpected behavior may occur");
54+
}
5155
converter_lut_[name] = std::move(converter);
5256
return true;
5357
}

0 commit comments

Comments
 (0)