Skip to content

Commit 858d8c3

Browse files
committed
fix(Windows)!: Fix dependency resolution for local builds
BREAKING CHANGE: Users on Windows trying to use cuDNN 8 must manually configure third_party/cudnn/local/BUILD to use cuDNN 8. Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent 83eb3ad commit 858d8c3

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Diff for: third_party/cudnn/local/BUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ cc_import(
2626
name = "cudnn_lib",
2727
shared_library = select({
2828
":aarch64_linux": "lib/aarch64-linux-gnu/libcudnn.so",
29-
":windows": glob(["bin/cudnn64_*.dll"])[0],
29+
":windows": "bin/cudnn64_7.dll", #Need to configure specific version for windows
3030
"//conditions:default": "lib/x86_64-linux-gnu/libcudnn.so",
3131
}),
3232
visibility = ["//visibility:private"],

Diff for: third_party/tensorrt/local/BUILD

-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ cc_import(
7272

7373
cc_library(
7474
name = "nvinfer",
75-
srcs = select({ ":windows": [ "lib/nvinfer.lib" ] }),
7675
deps = [
7776
"nvinfer_headers",
7877
"nvinfer_lib",

0 commit comments

Comments
 (0)