Skip to content

Commit a39dea7

Browse files
committed
feat(//.github): Linter throws 1 when there needs to be style changes to
show failing test to people whose PRs cant get linting inlined Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent 59868d2 commit a39dea7

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Diff for: .github/scripts/run_cpp_linter.py

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
if output.returncode != 0:
2424
comment = '''There are some changes that do not conform to C++ style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
2525
approval = 'REQUEST_CHANGES'
26+
exit(1)
2627

2728
pr.create_review(commit, comment, approval)
2829

Diff for: .github/scripts/run_py_linter.py

+1
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@
2323
if output.returncode != 0:
2424
comment = '''There are some changes that do not conform to Python style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
2525
approval = 'REQUEST_CHANGES'
26+
exit(1)
2627

2728
pr.create_review(commit, comment, approval)

0 commit comments

Comments
 (0)