Skip to content

Commit ece114c

Browse files
committed
feat(//.github): Moving to python directly
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent e72280a commit ece114c

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Diff for: .github/scripts/run_cpp_linter.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
pr = repo.get_pull(pr_number)
1717
commit = repo.get_commit(pr.base.sha)
1818

19-
output = subprocess.run(["bazel", "run", "//tools/linter:cpplint_diff", "--", "--no-color", "//..."], stdout=subprocess.PIPE)
19+
output = subprocess.run(["python3", "tools/linter/cpplint_diff.py", "--no-color", "//..."], stdout=subprocess.PIPE)
2020

2121
comment = '''Code conforms to C++ style guidelines'''
2222
approval = 'APPROVE'

Diff for: .github/scripts/run_py_linter.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
pr = repo.get_pull(pr_number)
1717
commit = repo.get_commit(pr.base.sha)
1818

19-
output = subprocess.run(["bazel", "run", "//tools/linter:pylint_diff", "--", "//..."], stdout=subprocess.PIPE)
19+
output = subprocess.run(["python3", "tools/linter:pylint_diff", "//..."], stdout=subprocess.PIPE)
2020

2121
comment = '''Code conforms to Python style guidelines'''
2222
approval = 'APPROVE'

Diff for: .github/workflows/linter.yml

+1
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,6 @@ jobs:
4747
- name: Install dependencies
4848
run: |
4949
docker exec pylinter bash -c "pip3 install -r /workspace/.github/scripts/requirements.txt"
50+
docker exec pylinter bash -c "pip3 install -r /workspace/tools/linter/requirements.txt"
5051
- name: Lint Python
5152
run: docker exec pylinter bash -c "cd /workspace && python3 /workspace/.github/scripts/run_cpp_linter.py"

0 commit comments

Comments
 (0)