Skip to content

Commit 4568baf

Browse files
committed
Update formatting to fix warnings
1 parent 870edc2 commit 4568baf

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

Diff for: sdk-extension/opentelemetry-sdk-extension-aws/setup.cfg

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ package_dir=
3939
=src
4040
packages=find_namespace:
4141
install_requires =
42-
opentelemetry-api == 0.14.dev0
42+
opentelemetry-api == 0.14.b0
4343

4444
[options.entry_points]
4545
opentelemetry_propagator =
4646
aws_xray = opentelemetry.sdk.extension.aws.trace.propagation.aws_xray_format:AWSXRayFormat
4747

4848
[options.extras_require]
4949
test =
50-
opentelemetry-test == 0.14.dev0
50+
opentelemetry-test == 0.14.b0
5151

5252
[options.packages.find]
5353
where = src

Diff for: sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/propagation/aws_xray_format.py

+9-11
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414

1515
import typing
16-
from re import compile as re_compile
1716

1817
import logging
1918
import opentelemetry.trace as trace
@@ -64,7 +63,7 @@ def extract(
6463
context: typing.Optional[Context] = None,
6564
) -> Context:
6665
if not carrier:
67-
raise ValueError('Could not extract from carrier: %s'.format(carrier))
66+
raise ValueError(("Could not extract from carrier: %s", carrier))
6867

6968
trace_header = get_from_carrier(carrier, self.TRACE_HEADER_KEY)
7069

@@ -74,7 +73,6 @@ def extract(
7473
trace_id = trace.INVALID_TRACE_ID
7574
span_id = trace.INVALID_SPAN_ID
7675
sampled = False
77-
flags = None
7876

7977
next_kv_pair_start = 0
8078

@@ -83,34 +81,34 @@ def extract(
8381
kv_pair_delimiter_index = trace_header.index(self.KV_PAIR_DELIMITER, next_kv_pair_start)
8482
kv_pair_subset = trace_header[next_kv_pair_start:kv_pair_delimiter_index]
8583
next_kv_pair_start = kv_pair_delimiter_index + 1
86-
except ValueError as e:
84+
except ValueError as _:
8785
kv_pair_subset = trace_header[next_kv_pair_start:]
8886
next_kv_pair_start = len(trace_header)
8987

9088
stripped_kv_pair = kv_pair_subset.strip()
9189

9290
try:
9391
key_and_value_delimiter_index = stripped_kv_pair.index(self.KEY_AND_VALUE_DELIMITER)
94-
except ValueError as e:
95-
_logger.error("Error parsing X-Ray trace header. Invalid key value pair: %s. Returning INVALID span context.".format(kv_pair_subset))
92+
except ValueError as _:
93+
_logger.error(("Error parsing X-Ray trace header. Invalid key value pair: %s. Returning INVALID span context.", kv_pair_subset))
9694
return trace.set_span_in_context(trace.INVALID_SPAN)
9795

9896
value = stripped_kv_pair[key_and_value_delimiter_index + 1:]
9997

100-
if (stripped_kv_pair.startswith(self.TRACE_ID_KEY)):
98+
if stripped_kv_pair.startswith(self.TRACE_ID_KEY):
10199
if (len(value) != self.TRACE_ID_LENGTH or
102100
not value.startswith(self.TRACE_ID_VERSION) or
103101
value[self.TRACE_ID_DELIMITER_INDEX_1] != self.TRACE_ID_DELIMITER or
104102
value[self.TRACE_ID_DELIMITER_INDEX_2] != self.TRACE_ID_DELIMITER):
105-
_logger.error("Invalid TraceId in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.".format(self.TRACE_HEADER_KEY, trace_header))
103+
_logger.error(("Invalid TraceId in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.", self.TRACE_HEADER_KEY, trace_header))
106104
return trace.INVALID_SPAN_CONTEXT
107105

108106
timestamp_subset = value[self.TRACE_ID_DELIMITER_INDEX_1 + 1: self.TRACE_ID_DELIMITER_INDEX_2]
109107
unique_id_subset = value[self.TRACE_ID_DELIMITER_INDEX_2 + 1: self.TRACE_ID_LENGTH]
110108
trace_id = int(timestamp_subset + unique_id_subset, 16)
111109
elif stripped_kv_pair.startswith(self.PARENT_ID_KEY):
112110
if len(value) != self.PARENT_ID_LENGTH:
113-
_logger.error("Invalid ParentId in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.".format(self.TRACE_HEADER_KEY, trace_header))
111+
_logger.error(("Invalid ParentId in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.", self.TRACE_HEADER_KEY, trace_header))
114112
return trace.INVALID_SPAN_CONTEXT
115113

116114
span_id = int(value, 16)
@@ -130,7 +128,7 @@ def extract(
130128
is_sampled_flag_valid = False
131129

132130
if not is_sampled_flag_valid:
133-
_logger.error("Invalid Sampling flag in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.".format(self.TRACE_HEADER_KEY, trace_header))
131+
_logger.error(("Invalid Sampling flag in X-Ray trace header: '%s' with value '%s'. Returning INVALID span context.", self.TRACE_HEADER_KEY, trace_header))
134132
return trace.INVALID_SPAN_CONTEXT
135133

136134
options = 0
@@ -162,7 +160,7 @@ def inject(
162160
context: typing.Optional[Context] = None,
163161
) -> None:
164162
if not carrier:
165-
raise ValueError('Could not extract from carrier: %s'.format(carrier))
163+
raise ValueError(("Could not extract from carrier: %s", carrier))
166164

167165
span = trace.get_current_span(context=context)
168166

Diff for: sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = "0.14.dev0"
15+
__version__ = "0.14.b0"

0 commit comments

Comments
 (0)