fix(router): fix navigation when clearing history and navigating before the navigatedTo event fires #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the navigatedTo event fires
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e9ce80c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
NathanWalker
approved these changes
Nov 30, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Nov 30, 2022
…re the navigatedTo event fires (#100) * fix(router): fix navigation when clearing history and navigating before the navigatedTo event fires * fix: mark cache for clearing for better consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When navigating with clearHistory, we delay clearing the history until
navigatedTofires so the previous page doesn't become blank before the navigation animation finishes. This has a side-effect that if we quickly navigate the cache clear might happen after the next navigation, clearing the cache in a wrong way.What is the new behavior?
We now force clear the cache on route detach or deactivate if it hasn't been cleared yet, before any other cache manipulation has happened