Skip to content

fix(list-view): try to unwrap component views #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

If using a component without a native layout wrapper (stacklayout/etc), {N}'s listview will wrap the component in a layout. Doing so will break change detection

What is the new behavior?

We try to unwrap the view to fetch the stored template key

Fixes #30.

@cla-bot cla-bot bot added the cla: yes label Sep 3, 2021
@NathanWalker NathanWalker merged commit 81d7ffb into main Sep 6, 2021
@NathanWalker NathanWalker deleted the fix/list-view-components branch September 6, 2021 04:01
@NathanWalker
Copy link
Contributor

Published with 12.1.0-rc.5 - will be part of the official 12.1 release - we may jump to 12.2 to align with Angular's latest before taking latest main commits to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Component Inside Listview Template Not Updating with Async
2 participants