Debug via extension broken with VSCode 1.20

[andreaboriani]

Cannot run "Launch on android" nor "Attach on Android" after updating Visual Studio Code to version 1.2ù
Any workaround?

[cfirmo33]

waiting for this correction too.

[EddyVerbruggen]

Wondering if this is Windows-only.

Does anyone see this on macOS? I'm running VSCode 1.2 on macOS and extension version 0.7.2 and can attach/launch on Android just fine.

[NickIliev]

@EddyVerbruggen I've experienced this one on macOS as well.
However, the issue is not consistent on Mac while on Windows it is 100% reproducible

[EddyVerbruggen]

Hmm, macOS is rock solid for me (and I don't currently have a Windows machine at hand). For anyone experiencing this issue: I wonder if it would help if you change this in launch.json:

        {
            "name": "Launch on Android",
            "type": "nativescript",
            "request": "launch",
            "platform": "android",
            "appRoot": "${workspaceRoot}",
            "sourceMaps": true,
            "watch": true,
        },

to

        {
            "name": "Launch on Android",
            "tnsArgs": [
                "--debug-brk"
            ],
            "type": "nativescript",
            "request": "launch",
            "platform": "android",
            "appRoot": "${workspaceRoot}",
            "sourceMaps": true,
            "watch": true,
        },

so add that tnsArgs bit.

And if that works (the debugger should stop at the first NativeScript line that's executed), then please also test --debug instead of --debug-brk.

[tedekeroth]

Hey,
running win7, Vscode 1.20.1. Tried both --debug-brk and --debug, no change for me at least.

[andreaboriani]

Just to clarify, the problem is not debugging.
When you click 'Launch on Android' nothing happens. The debug console window remains empty, with no [NSDebugAdapter] nor [NativeScriptCli] shown.

[EddyVerbruggen]

Thanks for the feedback! Knowing that adding --debug(-brk) didn't help made me install a virtual Windows machine on my Mac to reproduce this issue myself.

After some fooling around in the codebase and trying to wrap my head around how the debugger server and client communicate (sockets, in this case) I found the issue and a solution... so expect a PR real soon.

[EddyVerbruggen]

⬆️ PR pending 🎉

[thaoula]

That is great news!!! When can we expect the PR to merged?

Currently debugging with the Chrome Dev tools is not an awesome experience.

[thaoula]

When will a new version of the Nativescript extension with theses fixes be pushed out?

[etabakov]

We are aiming to release it early next week. Meanwhile, you can try the latest bits by building the extensions from the latest master branch. There were already tested and no issues were found.

[EddyVerbruggen]

Cool! Thanks for merging this @etabakov 👍

[etabakov]

We thank you for the help with this issue 💯

[etabakov]

A new version was just published. Let us know how it goes!

[thaoula]

Hi @etabakov,

So I can now debug and vscode does not hang. However, quite frequently the process will timeout and debugging does not work.

I have also noticed node-sass is left running in the background, one for each time i try and use the debug function in vscode.

if I dont kills the node-sass process it will cause loop through transferring the files to the similator several times before you see broken app (css broken) and the following error in the console.

Error: Css styling failed: Error: undefined:1:16: missing '{'

I am running on Mac OS High Sierra and mainly trying to connect to IOS.

Regards,
Tarek

[etabakov]

Hey Tarek,

I believe these are separate issues that are not relevant to the problem that we solved in this issue. Can you open a separate issue and we will try to look at it? Also, I think there is a very similar issue reported already in a separate thread: NativeScript/nativescript-cli#3235

Thanks,
Emil

[thaoula]

Hi Emil,

I was also having a problem debugging with VS code up until this patch. Try to debug did nothing or hung vscode.

I will check out the issue you mentioned.

On a side note, are there any plans to create a mono repository for Nativescript so all toolchain issues and code are in a single repository?

Regards,
Tarek

[thaoula]

Hi @etabakov,

The last post on the issue use suggested was from me... can someone assist?

Regards,
Tarek

[etabakov]

We are currently working on a Release Candidate for 4.0 and the team is focused entirely on this task. After that we will probably be able to take a look at the issue and get back to you.

[thaoula]

Thank you very much. Looking forward to V4

…

On Fri, Mar 2, 2018 at 4:41 PM, Emil Tabakov ***@***.***> wrote: We are currently working on a Release Candidate for 4.0 and the team is focused entirely on this task. After that we will probably be able to take a look at the issue and get back to you. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#158 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVTzUJuEL8aFDJIvP-Oj352DLnOidrQks5taRPdgaJpZM4SAebx> .