Skip to content

Use chrome-debug-adapter-core #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 17, 2018
Merged

Use chrome-debug-adapter-core #181

merged 18 commits into from
Jul 17, 2018

Conversation

ivanovit
Copy link
Contributor

@ivanovit ivanovit commented Jun 1, 2018

Use https://github.com/Microsoft/vscode-chrome-debug-core and extract ns specific logic only:

  • NativeScriptPathTransformer - transform path from the device to project path.
  • NSDiscovery - returns the debug targets on the device. The default ChromeDiscovery calls localhost/json/list in order to list targets, but it's currently not supported by ns cli.
  • processRequest method is just moved. It basically do the build and get's the port to attach.
  • don't pass --no-client because we now use inspector protocol for debugging.

@ivanovit ivanovit self-assigned this Jun 1, 2018
bundyo
bundyo reviewed Jun 5, 2018
View reviewed changes
.vscode/launch.json Outdated
@@ -17,7 +17,7 @@
"name": "launch in extension host",
"type": "extensionHost",
"request": "launch",
// Path to VSCode executable
// Path to VSCode executablensDebugClient
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executablensDebugClient?

ivanovit added 18 commits July 17, 2018 10:15
@ivanovit
Use vscode-chrome-debug-core
55091b2
@ivanovit
Fix tests
96a38ed 
Kill process before debug session.
@ivanovit
Support iOS mapping
84d3d07
@ivanovit
Simplify logic
77a375d
@ivanovit
Fix iOS
10c6ae8
@ivanovit
Fix process kill and reuse logic
f2eea4b
@ivanovit
Remove ipc
473ca2c 
Use the debug adapter events
@ivanovit
Use chrome-debug-adapter logger
5b0177a 
Also added extension host logger
@ivanovit
Use semver to compare versions
b6b2d99
@ivanovit
Integrate tslint and fixes warnings
36d1430
@ivanovit
Add tests
75e43cd 
The deleted tests were focused on debug protocol. Now these scenarios should be covered by the chrome-debug-adapter-core. Currently, the new tests cover only NS related code.
@ivanovit
Add travis file
18114ad
@ivanovit
Update
d612d50
@ivanovit
Fix test
0930747 
Current tests for paths are generated for windows paths.
@ivanovit
Remove tslint disable
edbc11d
@ivanovit
Bring back tslint
373fc16
@ivanovit
Fix version parsing
cb4fcb5 
In the newer versions of CLI each command can print additional warning before the actual command output.
@ivanovit
Fix eslint
e8ef630
@ivanovit ivanovit force-pushed the iiivanov/use-chrome-debug-adapter-2 branch from f4410b4 to e8ef630 Compare July 17, 2018 07:15
@ivanovit ivanovit merged commit ca6b16f into master Jul 17, 2018
@ivanovit ivanovit deleted the iiivanov/use-chrome-debug-adapter-2 branch July 17, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bundyo bundyo bundyo approved these changes

@ventsislav-georgiev ventsislav-georgiev ventsislav-georgiev approved these changes

Assignees

@ivanovit ivanovit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovit @bundyo @ventsislav-georgiev