chore: nx migrate @nativescript/[email protected]

Author: NathanWalker

README.md

@@ -30,6 +30,11 @@ npm start
 
 This workspace manages the suite of plugins listed above. 
 
+## Prerequisites
+
+- Node 18+ is recommended
+- [yarn v1](https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable) is required
+
 In general, when in doubt with what to do, just `npm start`.
 
 ## How to add a new package to workspace?

package.json

@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "license": "MIT",
   "scripts": {
-    "postinstall": "husky install && npx ts-patch install",
+    "postinstall": "husky && npx ts-patch install",
     "setup": "npx rimraf node_modules package-lock.json dist tmp yarn.lock && yarn",
     "start": "nps",
     "add": "nx g @nativescript/plugin-tools:add-package",
@@ -28,7 +28,7 @@
     "@angular/router": "^18.0.0",
     "@nativescript/angular": "^18.0.0",
     "@nativescript/core": "~8.8.0",
-    "@nativescript/plugin-tools": "5.3.1",
+    "@nativescript/plugin-tools": "5.4.1",
     "@nativescript/types": "~8.8.0",
     "@nativescript/webpack": "~5.0.22",
     "@ngtools/webpack": "^18.0.0",

tools/scripts/build-finish.ts

@@ -1,6 +1,7 @@
 const ngPackage = require('ng-packagr');
 const path = require('path');
 const fs = require('fs-extra');
+const { serializeJson, parseJson } = require('@nx/devkit');
 
 const rootDir = path.resolve(path.join(__dirname, '..', '..'));
 const nxConfigPath = path.resolve(path.join(rootDir, 'nx.json'));
@@ -44,9 +45,31 @@ function copyAngularDist() {
     .catch((err) => console.error(err));
 }
 
+function cleanPackage() {
+  // helps remove unwanted properties which may be added by other tooling
+  const packageJsonPath = path.resolve(rootDir, 'dist', 'packages', packageName, 'package.json');
+  let packageJson = fs.readFileSync(packageJsonPath, { encoding: 'utf-8' });
+  if (packageJson) {
+    packageJson = parseJson(packageJson);
+    // we don't need module or type properties at the moment
+    delete packageJson['module'];
+    delete packageJson['type'];
+    fs.writeFileSync(packageJsonPath, serializeJson(packageJson));
+
+    const angularNpmIgnorePath = path.resolve(rootDir, 'dist', 'packages', packageName, 'angular', '.npmignore');
+    // remove .npmignore as we don't need it in angular folder if found
+    if (fs.existsSync(angularNpmIgnorePath)) {
+      fs.unlinkSync(angularNpmIgnorePath);
+    }
+  }
+}
+
 function finishPreparation() {
   fs.copy(path.join('tools', 'assets', 'publishing'), path.join('dist', 'packages', packageName))
-    .then(() => console.log(`${npmPackageName} ready to publish.`))
+    .then(() => {
+      cleanPackage();
+      console.log(`${npmPackageName} ready to publish.`);
+    })
     .catch((err) => console.error(err));
 }