Should Neogit use scratch buffer for NeogitConsole buffer?

[FirelightFlagboy]

Hello, today I've encountered this error when using Neogit:

Error executing vim.schedule lua callback: ...ck/myNeovimPackages/opt/neogit/lua/neogit/lib/buffer.lua:966: Vim:E325: ATTENTION                                                                                                                    
stack traceback:                                                                                                                                                                                                                                   
        [C]: in function 'nvim_buf_set_name'                                                                                                                                                                                                       
        ...ck/myNeovimPackages/opt/neogit/lua/neogit/lib/buffer.lua:966: in function 'from_name'                                                                                                                                                   
        ...ck/myNeovimPackages/opt/neogit/lua/neogit/lib/buffer.lua:688: in function 'create'                                                                                                                                                      
        ...mPackages/opt/neogit/lua/neogit/buffers/process/init.lua:102: in function 'open'                                                                                                                                                        
        ...mPackages/opt/neogit/lua/neogit/buffers/process/init.lua:48: in function 'show'                                                                                                                                                         
        .../pack/myNeovimPackages/opt/neogit/lua/neogit/process.lua:109: in function 'show_console'                                                                                                                                                
        .../pack/myNeovimPackages/opt/neogit/lua/neogit/process.lua:163: in function ''                                                                                                                                                            
        vim/_editor.lua: in function <vim/_editor.lua:0>

The ATTENTION message was that a swap file for the buffer NeogitConsole exist and what actions to take.

The presence of the swap file was confirmed by listing the list of Neovim swap files under ~/.local/state/nvim/swap:

%[redacted]%NeogitConsole.swo
%[redacted]%NeogitConsole.swp

The incriminated function in the exception is:

neogit/lua/neogit/lib/buffer.lua

Lines 966 to 976 in 7a3daec

	function Buffer.from_name(name)
	local buffer_handle = fn.bufnr(name)
	if buffer_handle == -1 then
	buffer_handle = api.nvim_create_buf(false, false)
	api.nvim_buf_set_name(buffer_handle, name)
	end
	local window_handle = fn.win_findbuf(buffer_handle)
	return Buffer:new(buffer_handle, window_handle[1])
	end

I imagine that would be fixed by creating the buffer with scratch = true when calling api.nvim_create_buf({listed}, {scratch}) but I'm not sure of the impact if we do that for all of the created buffer for Neogit (particularly for the buffer to edit the commit message)

[CKolkey]

Odd that there is a swap file, as that's explicitly disabled when creating buffers: https://github.com/neogitorg/neogit/blob/d0d8698000ca5d9322ea626313634c0dc71650d9/lua/neogit/lib/buffer.lua#L704

I'll experiment with setting it as a scratch buffer and see if there are any consequences for that. Thanks for letting me know

[FirelightFlagboy]

Thanks for looking it through