Skip to content

Commit 37e6f53

Browse files
authored
Revert "introduce git info by default" (#2376)
Reverts #2372
1 parent cff199c commit 37e6f53

File tree

3 files changed

+1
-200
lines changed

3 files changed

+1
-200
lines changed

metaflow/metadata_provider/metadata.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -630,20 +630,6 @@ def _get_system_info_as_dict(self):
630630
sys_info["r_version"] = env["r_version_code"]
631631
return sys_info
632632

633-
def _get_git_info_as_dict(self):
634-
git_info = {}
635-
env = self._environment.get_environment_info()
636-
for key in [
637-
"script",
638-
"repo_url",
639-
"branch_name",
640-
"commit_sha",
641-
"has_uncommitted_changes",
642-
]:
643-
if key in env and env[key]:
644-
git_info[key] = env[key]
645-
return git_info
646-
647633
def _get_system_tags(self):
648634
"""Convert system info dictionary into a list of system tags"""
649635
return [
@@ -684,16 +670,6 @@ def _register_system_metadata(self, run_id, step_name, task_id, attempt):
684670
tags=["attempt_id:{0}".format(attempt)],
685671
)
686672
)
687-
# And add git metadata
688-
metadata.extend(
689-
MetaDatum(
690-
field=str(k),
691-
value=str(v),
692-
type="git-info",
693-
tags=["attempt_id:{0}".format(attempt)],
694-
)
695-
for k, v in self._get_git_info_as_dict().items()
696-
)
697673
if metadata:
698674
self.register_metadata(run_id, step_name, task_id, metadata)
699675

metaflow/metaflow_environment.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
from .util import get_username
66
from . import metaflow_version
7-
from . import metaflow_git
87
from metaflow.exception import MetaflowException
98
from metaflow.extension_support import dump_module_info
109
from metaflow.mflog import BASH_MFLOG, BASH_FLUSH_LOGS
@@ -198,10 +197,6 @@ def get_environment_info(self, include_ext_info=False):
198197
"python_version_code": "%d.%d.%d" % sys.version_info[:3],
199198
"metaflow_version": metaflow_version.get_version(),
200199
"script": os.path.basename(os.path.abspath(sys.argv[0])),
201-
# Add git info
202-
**metaflow_git.get_repository_info(
203-
path=os.path.dirname(os.path.abspath(sys.argv[0]))
204-
),
205200
}
206201
if R.use_r():
207202
env["metaflow_r_version"] = R.metaflow_r_version()
@@ -211,7 +206,7 @@ def get_environment_info(self, include_ext_info=False):
211206
# Information about extension modules (to load them in the proper order)
212207
ext_key, ext_val = dump_module_info()
213208
env[ext_key] = ext_val
214-
return {k: v for k, v in env.items() if v is not None and v != ""}
209+
return env
215210

216211
def executable(self, step_name, default=None):
217212
if default is not None:

metaflow/metaflow_git.py

Lines changed: 0 additions & 170 deletions
This file was deleted.

0 commit comments

Comments
 (0)