Skip to content

Commit ddcab42

Browse files
refactor out a common definition when style=form (#3379)
1 parent 485f655 commit ddcab42

File tree

2 files changed

+48
-92
lines changed

2 files changed

+48
-92
lines changed

schemas/v3.1/schema.json

+29-57
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@
535535
"$ref": "#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-cookie"
536536
},
537537
{
538-
"$ref": "#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-form"
538+
"$ref": "#/$defs/styles-for-form"
539539
}
540540
],
541541
"$defs": {
@@ -640,32 +640,6 @@
640640
}
641641
}
642642
}
643-
},
644-
"styles-for-form": {
645-
"if": {
646-
"properties": {
647-
"style": {
648-
"const": "form"
649-
}
650-
},
651-
"required": [
652-
"style"
653-
]
654-
},
655-
"then": {
656-
"properties": {
657-
"explode": {
658-
"default": true
659-
}
660-
}
661-
},
662-
"else": {
663-
"properties": {
664-
"explode": {
665-
"default": false
666-
}
667-
}
668-
}
669643
}
670644
}
671645
}
@@ -792,38 +766,10 @@
792766
"$ref": "#/$defs/specification-extensions"
793767
},
794768
{
795-
"$ref": "#/$defs/encoding/$defs/explode-default"
769+
"$ref": "#/$defs/styles-for-form"
796770
}
797771
],
798-
"unevaluatedProperties": false,
799-
"$defs": {
800-
"explode-default": {
801-
"if": {
802-
"properties": {
803-
"style": {
804-
"const": "form"
805-
}
806-
},
807-
"required": [
808-
"style"
809-
]
810-
},
811-
"then": {
812-
"properties": {
813-
"explode": {
814-
"default": true
815-
}
816-
}
817-
},
818-
"else": {
819-
"properties": {
820-
"explode": {
821-
"default": false
822-
}
823-
}
824-
}
825-
}
826-
}
772+
"unevaluatedProperties": false
827773
},
828774
"responses": {
829775
"$comment": "https://spec.openapis.org/oas/v3.1.0#responses-object",
@@ -1444,6 +1390,32 @@
14441390
"additionalProperties": {
14451391
"type": "string"
14461392
}
1393+
},
1394+
"styles-for-form": {
1395+
"if": {
1396+
"properties": {
1397+
"style": {
1398+
"const": "form"
1399+
}
1400+
},
1401+
"required": [
1402+
"style"
1403+
]
1404+
},
1405+
"then": {
1406+
"properties": {
1407+
"explode": {
1408+
"default": true
1409+
}
1410+
}
1411+
},
1412+
"else": {
1413+
"properties": {
1414+
"explode": {
1415+
"default": false
1416+
}
1417+
}
1418+
}
14471419
}
14481420
}
14491421
}

schemas/v3.1/schema.yaml

+19-35
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ $defs:
369369
- $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-header'
370370
- $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-query'
371371
- $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-cookie'
372-
- $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-form'
372+
- $ref: '#/$defs/styles-for-form'
373373

374374
$defs:
375375
styles-for-path:
@@ -426,6 +426,7 @@ $defs:
426426
allowReserved:
427427
default: false
428428
type: boolean
429+
429430
styles-for-cookie:
430431
if:
431432
properties:
@@ -439,22 +440,6 @@ $defs:
439440
default: form
440441
const: form
441442

442-
styles-for-form:
443-
if:
444-
properties:
445-
style:
446-
const: form
447-
required:
448-
- style
449-
then:
450-
properties:
451-
explode:
452-
default: true
453-
else:
454-
properties:
455-
explode:
456-
default: false
457-
458443
$ref: '#/$defs/specification-extensions'
459444
unevaluatedProperties: false
460445

@@ -542,26 +527,9 @@ $defs:
542527
type: boolean
543528
allOf:
544529
- $ref: '#/$defs/specification-extensions'
545-
- $ref: '#/$defs/encoding/$defs/explode-default'
530+
- $ref: '#/$defs/styles-for-form'
546531
unevaluatedProperties: false
547532

548-
$defs:
549-
explode-default:
550-
if:
551-
properties:
552-
style:
553-
const: form
554-
required:
555-
- style
556-
then:
557-
properties:
558-
explode:
559-
default: true
560-
else:
561-
properties:
562-
explode:
563-
default: false
564-
565533
responses:
566534
$comment: https://spec.openapis.org/oas/v3.1.0#responses-object
567535
type: object
@@ -999,3 +967,19 @@ $defs:
999967
type: object
1000968
additionalProperties:
1001969
type: string
970+
971+
styles-for-form:
972+
if:
973+
properties:
974+
style:
975+
const: form
976+
required:
977+
- style
978+
then:
979+
properties:
980+
explode:
981+
default: true
982+
else:
983+
properties:
984+
explode:
985+
default: false

0 commit comments

Comments
 (0)