Skip to content

Commit fd21074

Browse files
committed
[REF] create a dedicated function _mark_migration_done_in_migration_issue
1 parent 654a78d commit fd21074

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/oca_github_bot/tasks/merge_bot.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from ..utils import hide_secrets
2828
from ..version_branch import make_merge_bot_branch, parse_merge_bot_branch
2929
from .main_branch_bot import main_branch_bot_actions
30-
from .migration_issue_bot import _check_line_issue, _find_issue
30+
from .migration_issue_bot import _mark_migration_done_in_migration_issue
3131

3232
_logger = getLogger(__name__)
3333

@@ -204,10 +204,7 @@ def _merge_bot_merge_pr(org, repo, merge_bot_branch, cwd, dry_run=False):
204204
github.gh_call(gh_pr.close)
205205

206206
# Check line in migration issue if required
207-
migration_issue = _find_issue(gh_repo, target_branch)
208-
if migration_issue:
209-
new_body = _check_line_issue(gh_pr.number, migration_issue.body)
210-
migration_issue.edit(body=new_body)
207+
_mark_migration_done_in_migration_issue(gh_repo, target_branch, gh_pr)
211208
return True
212209

213210

src/oca_github_bot/tasks/migration_issue_bot.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,13 @@ def _set_lines_issue(gh_pr_user_login, gh_pr_number, issue_body, module):
8383
return "\n".join(lines), old_pr_number
8484

8585

86+
def _mark_migration_done_in_migration_issue(gh_repo, target_branch, gh_pr):
87+
migration_issue = _find_issue(gh_repo, target_branch)
88+
if migration_issue:
89+
new_body = _check_line_issue(gh_pr.number, migration_issue.body)
90+
migration_issue.edit(body=new_body)
91+
92+
8693
@task()
8794
@switchable("migration_issue_bot")
8895
def migration_issue_start(org, repo, pr, username, module=None, dry_run=False):

0 commit comments

Comments
 (0)