Skip to content

Endpoint routing doesn't support Api versioned models #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CJHunter91 opened this issue Mar 31, 2020 · 5 comments
Open

Endpoint routing doesn't support Api versioned models #2103

CJHunter91 opened this issue Mar 31, 2020 · 5 comments
Assignees

Comments

@CJHunter91
Copy link

OData endpoint routing does not support API versioned models. Maybe it's not yet been implemented.
If so it would be good to know when it will be supported.

Assemblies affected

OData .Net lib 7.4.0-beta

Reproduce steps

I've tried using the ODataConventionModelBuilder, applying different versions of each model but it doesn't have the desired effect as all model versions are the same when calling different APIversioned controllers.

Expected result

versionedODataModelBuilder returns different versions of the models.

        app.UseEndpoints(endpoints =>
        {
            endpoints.MapVersionedODataRoutes("OData", "api", versionedODataModelBuilder.GetEdmModels());
        });

Actual result

There is no ability to add different versions of models

        app.UseEndpoints(endpoints =>
        {
            endpoints.MapODataRoute("OData", "api", model);
        });

Additional detail

Ideally the current extension method which is used on the MVC route builder could be used on the endpoint route builder.

@KenitoInc KenitoInc transferred this issue from OData/odata.net Mar 31, 2020
@KenitoInc
Copy link
Contributor

@CJHunter91 Hey, we are investigating this and will get back to you.

@xuzhg
Copy link
Member

xuzhg commented Mar 31, 2020

@CJHunter91 API-Version is not owned by OData team. I created a simple issue at API-version repo to link this issue to API-version repo. Let's figure out what/how to support Endpoint routing in API-version model.

@NetTecture
Copy link

The lonely person developing versioning has said he will work on it once 7.4 is out of beta (which it is in quite some time).

Totally NOT odata responsibility - they do not own api versioning.

When will 7.4 release? ;)

I hope that finally works out nicely. Also waiting for 7.4 to be released so that I Can get versioning so I can work on swagger again.

@xuzhg
Copy link
Member

xuzhg commented Mar 31, 2020

The lonely person developing versioning has said he will work on it once 7.4 is out of beta (which it is in quite some time).

Totally NOT odata responsibility - they do not own api versioning.

When will 7.4 release? ;)

I hope that finally works out nicely. Also waiting for 7.4 to be released so that I Can get versioning so I can work on swagger again.

Soon, :)

@cvraman
Copy link

cvraman commented Jul 16, 2020

Any update on the same ? Using API Versioning with endpoint routing and OData is a critical aspect for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants