Skip to content

Commit 7a5d795

Browse files
Omer-ShaharProgram4GitHub
authored and
Program4GitHub
committed
Add context
Add context Add Context
1 parent dc78f98 commit 7a5d795

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

core/api.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -863,6 +863,7 @@ ion-reorder,shadow
863863

864864
ion-reorder-group,none
865865
ion-reorder-group,prop,disabled,boolean,true,false,false
866+
ion-reorder-group,prop,context,any,null,false,false
866867
ion-reorder-group,method,complete,complete(listOrReorder?: boolean | any[] | undefined) => Promise<any>
867868
ion-reorder-group,event,ionItemReorder,ItemReorderEventDetail,true
868869

@@ -1263,4 +1264,4 @@ ion-virtual-scroll,prop,renderHeader,((item: any, index: number) => any) | undef
12631264
ion-virtual-scroll,prop,renderItem,((item: any, index: number) => any) | undefined,undefined,false,false
12641265
ion-virtual-scroll,method,checkEnd,checkEnd() => Promise<void>
12651266
ion-virtual-scroll,method,checkRange,checkRange(offset: number, len?: number) => Promise<void>
1266-
ion-virtual-scroll,method,positionForItem,positionForItem(index: number) => Promise<number>
1267+
ion-virtual-scroll,method,positionForItem,positionForItem(index: number) => Promise<number>

core/src/components.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1861,6 +1861,7 @@ export namespace Components {
18611861
* If `true`, the reorder will be hidden.
18621862
*/
18631863
'disabled': boolean;
1864+
'context':null
18641865
}
18651866
interface IonRippleEffect {
18661867
/**

core/src/components/reorder-group/reorder-group.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export class ReorderGroup implements ComponentInterface {
4444
this.gesture.enable(!this.disabled);
4545
}
4646
}
47+
@Prop() context = null;
4748

4849
/**
4950
* Event that needs to be listened to in order to complete the reorder action.
@@ -53,7 +54,9 @@ export class ReorderGroup implements ComponentInterface {
5354
@Event() ionItemReorder!: EventEmitter<ItemReorderEventDetail>;
5455

5556
async connectedCallback() {
56-
const contentEl = this.el.closest('ion-content');
57+
var contentEl;
58+
if (this.context !== null) contentEl = this.context;
59+
else contentEl = this.el.closest("ion-content");
5760
if (contentEl) {
5861
this.scrollEl = await contentEl.getScrollElement();
5962
}

0 commit comments

Comments
 (0)