Rubocop fixes

Author: dnnyjns

.rubocop-https---onehq-com-rubocop-yml

@@ -0,0 +1,202 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+
+AllCops:
+  TargetRubyVersion: 2.6
+  DisabledByDefault: true
+  Exclude:
+    - "**/spec/**/*"
+
+Bundler:
+  Enabled: true
+
+Gemspec:
+  Enabled: true
+
+Lint:
+  Enabled: true
+
+Naming:
+  Enabled: true
+
+Rails:
+  Enabled: True
+
+Performance:
+  Enabled: True
+
+Security:
+  Enabled: True
+
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+  AutoCorrect: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/IndentFirstArgument:
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Enabled: true
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeComment:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+  EnforcedStyleForEmptyBraces: space
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Detect hard tabs, no hard tabs.
+Layout/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Naming/PredicateName:
+  Enabled: false
+
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+Rails/Output:
+  Enabled: false
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+  EnforcedStyle: context_dependent
+
+# Prefer Foo.method over Foo::method
+Style/ColonMethodCall:
+  Enabled: true
+
+Style/DefWithParentheses:
+  Enabled: true
+
+Style/BlockDelimiters:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/ParenthesesAroundCondition:
+  Enabled: true
+
+Style/RedundantBegin:
+  Enabled: true
+
+Style/RedundantFreeze:
+  Enabled: true
+
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/TrivialAccessors:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true

.rubocop.yml

@@ -0,0 +1,2 @@
+inherit_from:
+  - https://onehq.com/rubocop.yml

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec

Rakefile

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 begin
-  require 'bundler/setup'
+  require "bundler/setup"
 rescue LoadError
-  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
+  puts "You must `gem install bundler` and `bundle install` to run rake tasks"
 end
 
-require 'rdoc/task'
+require "rdoc/task"
 
 RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'HQ::GraphQL'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
+  rdoc.rdoc_dir = "rdoc"
+  rdoc.title    = "HQ::GraphQL"
+  rdoc.options << "--line-numbers"
+  rdoc.rdoc_files.include("README.rdoc")
+  rdoc.rdoc_files.include("lib/**/*.rb")
 end
 
-require 'bundler/gem_tasks'
+require "bundler/gem_tasks"

hq-graphql.gemspec

@@ -29,4 +29,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency "rspec",                                   "~> 3.8"
   s.add_development_dependency "rspec-rails",                             ">= 4.0.0beta2"
+  s.add_development_dependency "rubocop",                                 "~> 0.7"
+  s.add_development_dependency "rubocop-performance",                     "~> 1.4"
+  s.add_development_dependency "rubocop-rails",                           "~> 2.3"
 end

lib/hq-graphql.rb

@@ -1 +1,5 @@
+# rubocop:disable Naming/FileName
+# rubocop:enable Naming/FileName
+# frozen_string_literal: true
+
 require "hq/graphql"

lib/hq/graphql.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require "rails"
 require "graphql"
 
 module HQ
   module GraphQL
-
     def self.config
       @config ||= ::ActiveSupport::OrderedOptions.new
     end
@@ -30,7 +31,6 @@ def self.root_queries
     def self.types
       @types ||= Set.new
     end
-
   end
 end
 

lib/hq/graphql/active_record_extensions.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     module ActiveRecordExtensions
       class Error < StandardError
-        MISSING_MODEL_MSG = "Your GraphQL object must be connected to a model: `::HQ::GraphQL::Object.with_model 'User'`".freeze
-        MISSING_ATTR_MSG = "Can't find attr %{model}.%{attr}'`".freeze
-        MISSING_ASSOC_MSG = "Can't find association %{model}.%{assoc}'`".freeze
+        MISSING_MODEL_MSG = "Your GraphQL object must be connected to a model: `::HQ::GraphQL::Object.with_model 'User'`"
+        MISSING_ATTR_MSG = "Can't find attr %{model}.%{attr}'`"
+        MISSING_ASSOC_MSG = "Can't find association %{model}.%{assoc}'`"
       end
 
       def self.included(base)
@@ -118,7 +120,6 @@ def validate_model!
             model_name || raise(Error, Error::MISSING_MODEL_MSG)
           end
         end
-
       end
     end
   end

lib/hq/graphql/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     class Engine < ::Rails::Engine

lib/hq/graphql/input_object.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     class InputObject < ::GraphQL::Schema::InputObject
@@ -25,9 +27,7 @@ def format_nested_attributes
         end
       end
 
-      def with_indifferent_access
-        to_h.with_indifferent_access
-      end
+      delegate :with_indifferent_access, to: :to_h
 
       #### Class Methods ####
 
@@ -72,7 +72,7 @@ def argument_from_association(association)
             argument name, input, required: false
           end
 
-          if !model_klass.nested_attributes_options.keys.include?(name.to_sym)
+          if !model_klass.nested_attributes_options.key?(name.to_sym)
             model_klass.accepts_nested_attributes_for name, allow_destroy: true
           end
 
@@ -85,7 +85,6 @@ def argument_from_column(column)
           argument column.name, ::HQ::GraphQL::Types.type_from_column(column), required: false
         end
       end
-
     end
   end
 end

lib/hq/graphql/inputs.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     module Inputs
       class Error < StandardError
-        MISSING_TYPE_MSG = "The GraphQL type for `%{klass}` is missing.".freeze
+        MISSING_TYPE_MSG = "The GraphQL type for `%{klass}` is missing."
       end
 
       def self.[](key)
@@ -26,7 +28,6 @@ def klass_for(klass_or_string)
              raise(Error, Error::MISSING_TYPE_MSG % { klass: klass.name })
         end
       end
-
     end
   end
 end

lib/hq/graphql/mutation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     class Mutation < ::GraphQL::Schema::Mutation
@@ -8,7 +10,6 @@ def self.generate_payload_type
         lazy_load!
         super
       end
-
     end
   end
 end

lib/hq/graphql/object.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HQ
   module GraphQL
     class Object < ::GraphQL::Schema::Object
@@ -45,7 +47,6 @@ def field_from_column(column)
           field column.name, ::HQ::GraphQL::Types.type_from_column(column), null: true
         end
       end
-
     end
   end
 end