Addressed Jorge's comments

Author: Linsen Wu

Diff for: src/components/notebookRenderStrategy.tsx

@@ -12,7 +12,6 @@ import { NotebookOpenedIconSvg } from './icons/notebookOpenedIcon.svg';
 import { NotebookClosedIconSvg } from './icons/notebookClosedIcon.svg';
 import { ChevronSvg } from './icons/chevron.svg';
 import { CreateNewSectionNode } from './createNewSection/createNewSectionNode';
-import * as OneNoteApi from 'onenoteapi';
 import { SpinnerIconSvg } from './icons/spinnerIcon.svg';
 import { Strings } from '../strings';
 
@@ -46,8 +45,8 @@ export class NotebookRenderStrategy implements ExpandableNodeRenderStrategy {
 	}
 
 	getChildren(childrenLevel: number): JSX.Element[] {
-		if (typeof (this.notebook.apiHttpErrorCode) === 'number') {
-			const errorString = Strings.getError(this.notebook.apiHttpErrorCode);
+		if (this.notebook.apiHttpErrorMessage) {
+			const errorString = this.notebook.apiHttpErrorMessage;
 			return [
 				<li role='status' aria-live='polite' aria-label={errorString} className='progress-row'>
 					<div>{errorString}</div>
@@ -144,15 +143,19 @@ export class NotebookRenderStrategy implements ExpandableNodeRenderStrategy {
 	}
 
 	private onExpand() {
-		if (this.notebook.needsToFetchChildren && this.notebook.apiUrl && this.globals.oneNoteDataProvider && !!this.globals.callbacks.onNotebookInfoReturned) {
+		if (this.notebook.needsToFetchChildren && this.notebook.apiUrl && this.globals.oneNoteDataProvider) {
 			this.globals.oneNoteDataProvider.getNotebookBySelfUrl(this.notebook.apiUrl, 5).then((notebook) => {
 				this.notebook.sections = notebook.sections
 				this.notebook.sectionGroups = notebook.sectionGroups
-			}).catch((apiError: OneNoteApi.RequestError) => {
-				this.notebook.apiHttpErrorCode = apiError.statusCode;
+			}).catch((apiError: any) => {
+				try {
+					this.notebook.apiHttpErrorMessage = JSON.parse(apiError.response).error.message
+				} catch (error) {
+					this.notebook.apiHttpErrorMessage = Strings.getError(apiError.statusCode);
+				}
 			}).then(() => {
 				this.notebook.needsToFetchChildren = false;
-				if (!!this.globals.callbacks.onNotebookInfoReturned) {
+				if (this.globals.callbacks.onNotebookInfoReturned) {
 					this.globals.callbacks.onNotebookInfoReturned(this.notebook);
 				}
 			})

Diff for: src/components/sharedNotebookRenderStrategy.tsx

@@ -15,7 +15,6 @@ import { NotebookClosedIconSvg } from './icons/notebookClosedIcon.svg';
 import { SpinnerIconSvg } from './icons/spinnerIcon.svg';
 import { ChevronSvg } from './icons/chevron.svg';
 import { CreateNewSectionNode } from './createNewSection/createNewSectionNode';
-import * as OneNoteApi from 'onenoteapi';
 
 export class SharedNotebookRenderStrategy implements ExpandableNodeRenderStrategy {
 	onClickBinded = () => {};
@@ -52,8 +51,8 @@ export class SharedNotebookRenderStrategy implements ExpandableNodeRenderStrateg
 	}
 
 	getChildren(childrenLevel: number): JSX.Element[] {
-		if (typeof (this.notebook.apiHttpErrorCode) === 'number') {
-			const errorString = Strings.getError(this.notebook.apiHttpErrorCode);
+		if (this.notebook.apiHttpErrorMessage) {
+			const errorString = this.notebook.apiHttpErrorMessage;
 			return [
 				<li role='status' aria-live='polite' aria-label={errorString} className='progress-row'>
 					<div>{errorString}</div>
@@ -155,7 +154,7 @@ export class SharedNotebookRenderStrategy implements ExpandableNodeRenderStrateg
 
 			this.globals.oneNoteDataProvider.getSpNotebookProperties(this.notebook, depth, true).then((apiProperties) => {
 				if (!apiProperties) {
-					this.notebook.apiHttpErrorCode = 404;
+					this.notebook.apiHttpErrorMessage = Strings.getError(404);
 					return;
 				}
 
@@ -164,8 +163,12 @@ export class SharedNotebookRenderStrategy implements ExpandableNodeRenderStrateg
 				if (this.globals.notebookListUpdater) {
 					this.globals.notebookListUpdater.updateNotebookList([this.notebook]);
 				}
-			}).catch((apiError: OneNoteApi.RequestError) => {
-				this.notebook.apiHttpErrorCode = apiError.statusCode;
+			}).catch((apiError: any) => {
+				try {
+					this.notebook.apiHttpErrorMessage = JSON.parse(apiError.response).error.message
+				} catch (error) {
+					this.notebook.apiHttpErrorMessage = Strings.getError(apiError.statusCode);
+				}
 			}).then(() => {
 				const { onSharedNotebookInfoReturned } = this.globals.callbacks;
 				if (!!onSharedNotebookInfoReturned) {

Diff for: src/oneNoteDataStructures/notebook.ts

@@ -4,7 +4,7 @@ import { SectionGroup } from './sectionGroup';
 
 export interface Notebook extends OneNoteItem {
 	// Properties that need to be loaded-on-demand
-	apiHttpErrorCode?: number;
+	apiHttpErrorMessage?: string;
 
 	expanded: boolean;
 	sectionGroups: SectionGroup[];