[BUG] [typescript-angular] Angular 8: generated package.json includes @angular/http dependency

[daniel-sc]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• What's the version of OpenAPI Generator used?
• Have you search for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Bounty to sponsor the fix (example)

Description

When generating for angular-typescript and setting the Angular version to 8.x (e.g. 8.1.1) the generated package.json is invalid, as the included @angular/http is not available in version 8.1.1.

openapi-generator version

4.0.3

Steps to reproduce

Generate with <ngVersion>8.1.1</ngVersion>

Suggest a fix

The dependency @angular/http should be removed from the generated package.json as it is now included in @angular/common - see e.g.: https://blog.angularindepth.com/embrace-yourself-angular-8-is-coming-1bf187c8f0bf

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[macjohnny]

@daniel-sc would you like to file a PR to fix that?

[macjohnny]

you could use the {{#useHttpClient}} variable, see e.g.

openapi-generator/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

Lines 5 to 15 in a3cf964

	{{#useHttpClient}}
	import { HttpClient, HttpHeaders, HttpParams,
	HttpResponse, HttpEvent, HttpParameterCodec } from '@angular/common/http';
	import { CustomHttpParameterCodec } from '../encoder';
	{{/useHttpClient}}
	{{^useHttpClient}}
	import { Http, Headers, URLSearchParams,
	RequestMethod, RequestOptions, RequestOptionsArgs,
	Response, ResponseContentType, QueryEncoder } from '@angular/http';
	import { CustomQueryEncoderHelper } from '../encoder';
	{{/useHttpClient}}

[eseliger]

@macjohnny I have a fix for that ready, I can submit a pr in a few

[macjohnny]

@eseliger that would be great!