Skip to content

[BUG] typescript-node mixes require and import #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 6 tasks
DanielRuf opened this issue Dec 1, 2019 · 4 comments · Fixed by #6947
Closed
4 of 6 tasks

[BUG] typescript-node mixes require and import #4656

DanielRuf opened this issue Dec 1, 2019 · 4 comments · Fixed by #6947

Comments

@DanielRuf
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

When running openapi-generator generate -i https://petstore3.swagger.io/api/v3/openapi.json -g typescript-node -o out -c config.json

with the config.json file:

{
    "npmName": "@swagger/typescript-fetch-petstore",
    "npmVersion": "1.0.0",
    "npmRepository": "https://skimdb.npmjs.com/registry",
    "snapshot": false,
    "supportsES6": true
}

it generates the following code which is not valid esm code:

import localVarRequest = require('request');
import http = require('http');
openapi-generator version

4.2.0

OpenAPI declaration file content or url
Command line used for generation
Steps to reproduce
Related issues/PRs
Suggest a fix
@auto-labeler
Copy link

auto-labeler bot commented Dec 1, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@macjohnny
Copy link
Member

@DanielRuf would you like to implement a fix?

@DanielRuf DanielRuf changed the title [BUG] typescript-node mixes reuiqre and import [BUG] typescript-node mixes require and import Dec 3, 2019
@laubfall
Copy link
Contributor

Just for your information: i ran into the same problem and fixed this issue in https://github.com/laubfall/openapi-generator/tree/typescript-node_mixes_require_and_import_4656 . PR is on its way.

@laubfall
Copy link
Contributor

laubfall commented Jul 15, 2020

PR: #6947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants